Mailing List Archive

addPrediction bug?
This is a multi-part message in MIME format.

------=_NextPart_000_0005_01BF91B9.3F61BB10
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi,

Just downloaded the code for a peek and saw

int addPrediction(request_rec *e, int *servers, int *n, char *arg) {
int addload;
if(!*n) return *n;
addload =3D serverstats[0].tatime/6000+1;
if(servers[0] =3D=3D 0) addload>>1;
serverstats[servers[0]].load+=3Daddload;
return *n;
}

looks like you may have meant addload >>=3D 1

------=_NextPart_000_0005_01BF91B9.3F61BB10
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content=3D"text/html; charset=3Diso-8859-1" =
http-equiv=3DContent-Type>
<META content=3D"MSHTML 5.00.2314.1000" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>Hi,</FONT></DIV>
<DIV>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>Just downloaded the code for a peek and =

saw</FONT></DIV>
<DIV>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>int addPrediction(request_rec *e, int =
*servers, int=20
*n, char *arg) {<BR>&nbsp; int addload;<BR>&nbsp; if(!*n) return =
*n;<BR>&nbsp;=20
addload =3D serverstats[0].tatime/6000+1;<BR>&nbsp; if(servers[0] =3D=3D =
0)=20
addload&gt;&gt;1;<BR>&nbsp; =
serverstats[servers[0]].load+=3Daddload;<BR>&nbsp;=20
return *n;<BR>}</FONT></DIV>
<DIV>&nbsp;</DIV>
<DIV><FONT face=3DArial size=3D2>looks like you may have meant addload =
&gt;&gt;=3D=20
1</FONT></DIV></BODY></HTML>

------=_NextPart_000_0005_01BF91B9.3F61BB10--
addPrediction bug? [ In reply to ]
> Gary Hallmark wrote:
> looks like you may have meant addload >>= 1

Indeed. Thanks, I will fix that for the next release. This is the
snippet that adds only have the estimated load to the local instance.
This is an adhoc mechanism for preferring one's self over proxying.

--
Theo Schlossnagle
33131B65/2047/71 F7 95 64 49 76 5D BA 3D 90 B9 9F BE 27 24 E7