Mailing List Archive: Whoops!

Whoops!

Oct 14, 1995, 4:01 AM

Post #1 of 6 (614 views)

Just noticed a bug in the 07_SocketMemLeak patch... non-fatal, I guess this
should go in the 0.8.15 patchlist (if someone could put it there, please)

From: ben@algroup.co.uk (Ben Laurie)
Subject: Use pfclose() on timeout
Affects: http_main.c
Changelog: Use pfclose() instead of fclose() on a timeout.

*** ../../apache_0.8.14/src/http_main.c Tue Sep 19 17:05:01 1995
--- http_main.c Sat Oct 14 11:54:41 1995
***************
*** 255,262 ****

log_transaction(timeout_req);

! fclose (timeout_req->connection->client);
! fclose (timeout_req->connection->request_in);

if (!standalone) exit(0);
#ifdef NEXT
--- 255,262 ----

log_transaction(timeout_req);

! pfclose (timeout_req->connection->pool,timeout_req->connection->client);

! pfclose (timeout_req->connection->pool,timeout_req->connection->request_in);

if (!standalone) exit(0);
#ifdef NEXT

Cheers,

Ben.

--
Ben Laurie Phone: +44 (181) 994 6435
Freelance Consultant Fax: +44 (181) 994 6472
and Technical Director Email: ben@algroup.co.uk
A.L. Digital Ltd,
London, England.

Re: Whoops! [ In reply to ]

rst at ai

Oct 14, 1995, 6:57 AM

Post #2 of 6 (616 views)

Permalink

Uh-oh... that's a core dump on Linux. It's probably worth holding up
0.8.15 until we decide what to do about this...

rst

Re: Whoops! [ In reply to ]

rst at ai

Oct 14, 1995, 7:09 AM

Post #3 of 6 (613 views)

Permalink

FYI, my tentative 0.8.15 build (without Ben's post-patch) is in
ftp://ftp.ai.mit.edu/pub/users/rst, for people who want something to
start testing now...

rst

Re: Whoops! [ In reply to ]

hartill at ooo

Oct 14, 1995, 12:36 PM

Post #4 of 6 (608 views)

Permalink

> Uh-oh... that's a core dump on Linux. It's probably worth holding up
> 0.8.15 until we decide what to do about this...

I think we should close our eyes, count to ten, then when we open them,
the problem might be gone.

or, add the correction and continue as planned.

rob

Re: Whoops! [ In reply to ]

fielding at avron

Oct 14, 1995, 3:28 PM

Post #5 of 6 (607 views)

Permalink

>> Uh-oh... that's a core dump on Linux. It's probably worth holding up
>> 0.8.15 until we decide what to do about this...
>
> I think we should close our eyes, count to ten, then when we open them,
> the problem might be gone.
>
> or, add the correction and continue as planned.

I'll add my +1 to rob's and rst's -- go ahead and fix it.

....Roy

Re: Whoops! [ In reply to ]

awm at qosina

Oct 14, 1995, 7:41 PM

Post #6 of 6 (612 views)

Permalink

>
> Uh-oh... that's a core dump on Linux. It's probably worth holding up
> 0.8.15 until we decide what to do about this...
>
> rst
>

I haven;'t had any problem with it. I'm running 0.8.14 + patches. I'm
gonna grab 0.8.15 from your ftp site tonight and try it out.

<Aram>
--

Aram Mirzadeh
awm@qosina.com,awm@hyperreal.com
http://www.qosina.com/~awm/

43rd Law of Computing:
Anything that can go wr
Segmentation violation -- Core dumped