Mailing List Archive: DBM auth fix (?)

Could someone who uses DBM auth try this out, and make sure that it
doesn't break anything?

*** mod_auth_dbm.c~ Mon Jul 31 20:46:11 1995
--- mod_auth_dbm.c Tue Aug 8 12:46:05 1995
***************
*** 182,193 ****
char errstr[MAX_STRING_LEN];

array_header *reqs_arr = requires (r);
! require_line *reqs = (require_line *)reqs_arr->elts;

register int x;
char *t, *w;

if (!sec->auth_dbmgrpfile) return DECLINED;

for(x=0; x < reqs_arr->nelts; x++) {

--- 182,194 ----
char errstr[MAX_STRING_LEN];

array_header *reqs_arr = requires (r);
! require_line *reqs = reqs_arr ? (require_line *)reqs_arr->elts : NULL;

register int x;
char *t, *w;

if (!sec->auth_dbmgrpfile) return DECLINED;
+ if (!reqs_arr) return DECLINED;

for(x=0; x < reqs_arr->nelts; x++) {

Doesn't appear to break authentication, looks like it works fine (this
from testing 0.8.9 from rst's ai FTP server)

Brian

On Tue, 8 Aug 1995, Robert S. Thau wrote:
> Could someone who uses DBM auth try this out, and make sure that it
> doesn't break anything?
>
> *** mod_auth_dbm.c~ Mon Jul 31 20:46:11 1995
> --- mod_auth_dbm.c Tue Aug 8 12:46:05 1995
> ***************
> *** 182,193 ****
> char errstr[MAX_STRING_LEN];
>
> array_header *reqs_arr = requires (r);
> ! require_line *reqs = (require_line *)reqs_arr->elts;
>
> register int x;
> char *t, *w;
>
> if (!sec->auth_dbmgrpfile) return DECLINED;
>
> for(x=0; x < reqs_arr->nelts; x++) {
>
> --- 182,194 ----
> char errstr[MAX_STRING_LEN];
>
> array_header *reqs_arr = requires (r);
> ! require_line *reqs = reqs_arr ? (require_line *)reqs_arr->elts : NULL;
>
> register int x;
> char *t, *w;
>
> if (!sec->auth_dbmgrpfile) return DECLINED;
> + if (!reqs_arr) return DECLINED;
>
> for(x=0; x < reqs_arr->nelts; x++) {
>
>

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com brian@hyperreal.com http://www.[hyperreal,organic].com/