Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Xen>
  3. Devel
[PATCH v2 3/3] tools/golang: Run `go vet` as part of the build process
george.dunlap at cloud
Apr 19, 2024, 6:51 AM
Post #1 of 2 (13 views)
Permalink
Signed-off-by: George Dunlap <george.dunlap@cloud.com>
---
CC: Nick Rosbrook <rosbrookn@gmail.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
tools/golang/xenlight/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
index c5bb6b94a8..645e7b3a82 100644
--- a/tools/golang/xenlight/Makefile
+++ b/tools/golang/xenlight/Makefile
@@ -29,6 +29,7 @@ $(subst .gen.,.%.,$(GOXL_GEN_FILES)): gengotypes.py $(LIBXL_SRC_DIR)/libxl_types
# so that it can find the actual library.
.PHONY: build
build: xenlight.go $(GOXL_GEN_FILES)
+ CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) $(APPEND_LDFLAGS)" $(GO) vet
CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) $(APPEND_LDFLAGS)" $(GO) build -x

.PHONY: install
--
2.25.1
Re: [PATCH v2 3/3] tools/golang: Run `go vet` as part of the build process [ In reply to ]
rosbrookn at gmail
Apr 19, 2024, 8:31 AM
Post #2 of 2 (13 views)
Permalink
On Fri, Apr 19, 2024 at 10:00?AM George Dunlap <george.dunlap@cloud.com> wrote:
>
> Signed-off-by: George Dunlap <george.dunlap@cloud.com>
> ---
> CC: Nick Rosbrook <rosbrookn@gmail.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> ---
> tools/golang/xenlight/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
> index c5bb6b94a8..645e7b3a82 100644
> --- a/tools/golang/xenlight/Makefile
> +++ b/tools/golang/xenlight/Makefile
> @@ -29,6 +29,7 @@ $(subst .gen.,.%.,$(GOXL_GEN_FILES)): gengotypes.py $(LIBXL_SRC_DIR)/libxl_types
> # so that it can find the actual library.
> .PHONY: build
> build: xenlight.go $(GOXL_GEN_FILES)
> + CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) $(APPEND_LDFLAGS)" $(GO) vet
> CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) $(APPEND_LDFLAGS)" $(GO) build -x
>
> .PHONY: install
> --
> 2.25.1
>
Acked-by: Nick Rosbrook <rosbrookn@gmail.com>

Thanks,
Nick

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal