Mailing List Archive: [PATCH 0/2] Add Xen CpusAccel

[PATCH 0/2] Add Xen CpusAccel

Oct 12, 2020, 1:07 PM

Post #1 of 3 (34 views)

Xen was left behind when CpusAccel became mandatory and fails the assert
in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
Move the qtest cpu functions to a common location and reuse them for
Xen.

Jason Andryuk (2):
accel: move qtest CpusAccel functions to a common location
accel: Add xen CpusAccel using dummy-cpu

.../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +++++--------------
.../qtest-cpus.h => dummy/dummy-cpus.h} | 10 ++++-----
accel/dummy/meson.build | 7 ++++++
accel/meson.build | 1 +
accel/qtest/meson.build | 1 -
accel/qtest/qtest.c | 7 +++++-
accel/xen/xen-all.c | 10 +++++++++
7 files changed, 34 insertions(+), 24 deletions(-)
rename accel/{qtest/qtest-cpus.c => dummy/dummy-cpus.c} (76%)
rename accel/{qtest/qtest-cpus.h => dummy/dummy-cpus.h} (59%)
create mode 100644 accel/dummy/meson.build

--
2.25.1

Re: [PATCH 0/2] Add Xen CpusAccel [ In reply to ]

cfontana at suse

Oct 12, 2020, 1:16 PM

Post #2 of 3 (34 views)

Permalink

On 10/12/20 10:07 PM, Jason Andryuk wrote:
> Xen was left behind when CpusAccel became mandatory and fails the assert
> in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
> Move the qtest cpu functions to a common location and reuse them for
> Xen.
>
> Jason Andryuk (2):
> accel: move qtest CpusAccel functions to a common location
> accel: Add xen CpusAccel using dummy-cpu
>
> .../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +++++--------------
> .../qtest-cpus.h => dummy/dummy-cpus.h} | 10 ++++-----
> accel/dummy/meson.build | 7 ++++++
> accel/meson.build | 1 +
> accel/qtest/meson.build | 1 -
> accel/qtest/qtest.c | 7 +++++-
> accel/xen/xen-all.c | 10 +++++++++
> 7 files changed, 34 insertions(+), 24 deletions(-)
> rename accel/{qtest/qtest-cpus.c => dummy/dummy-cpus.c} (76%)
> rename accel/{qtest/qtest-cpus.h => dummy/dummy-cpus.h} (59%)
> create mode 100644 accel/dummy/meson.build
>

Yep, forgot completely, sorry.

Acked-by: Claudio Fontana <cfontana@suse.de>

Re: [PATCH 0/2] Add Xen CpusAccel [ In reply to ]

philmd at redhat

Oct 13, 2020, 1:42 AM

Post #3 of 3 (34 views)

Permalink

On 10/12/20 10:16 PM, Claudio Fontana wrote:
> On 10/12/20 10:07 PM, Jason Andryuk wrote:
>> Xen was left behind when CpusAccel became mandatory and fails the assert
>> in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
>> Move the qtest cpu functions to a common location and reuse them for
>> Xen.
>>
>> Jason Andryuk (2):
>> accel: move qtest CpusAccel functions to a common location
>> accel: Add xen CpusAccel using dummy-cpu
>>
>> .../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +++++--------------
>> .../qtest-cpus.h => dummy/dummy-cpus.h} | 10 ++++-----
>> accel/dummy/meson.build | 7 ++++++
>> accel/meson.build | 1 +
>> accel/qtest/meson.build | 1 -
>> accel/qtest/qtest.c | 7 +++++-
>> accel/xen/xen-all.c | 10 +++++++++
>> 7 files changed, 34 insertions(+), 24 deletions(-)
>> rename accel/{qtest/qtest-cpus.c => dummy/dummy-cpus.c} (76%)
>> rename accel/{qtest/qtest-cpus.h => dummy/dummy-cpus.h} (59%)
>> create mode 100644 accel/dummy/meson.build
>>
>
> Yep, forgot completely, sorry.

Good opportunity to ask the Xen folks to add testing
to our Gitlab CI, so this doesn't happen again :)

>
> Acked-by: Claudio Fontana <cfontana@suse.de>
>
>
>