Mailing List Archive: [PATCH] Correctly expose PCH ISA bridge for IGD passthrough (was PCI-PCI bridge)

[PATCH] Correctly expose PCH ISA bridge for IGD passthrough (was PCI-PCI bridge)

Dec 18, 2012, 7:37 AM

Post #1 of 4 (94 views)

Hi Stefano,

Per your request, I resend your patch with my local modification to
fix the PCH ISA bridge to be exposed correctly to domU. This is XEN
part of the fix to make i915 driver properly detect the PCH version.
Another patch for i915 driver side is required too. I'll send that to
intel-gfx list separately. The combined patch set do fix the PCH
detection issue for me.

Thanks,
Timothy

diff --git a/hw/pci.c b/hw/pci.c
index f051de1..d371bd7 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -871,11 +871,6 @@ void pci_unplug_netifs(void)
}
}

-typedef struct {
- PCIDevice dev;
- PCIBus *bus;
-} PCIBridge;
-
void pci_bridge_write_config(
PCIDevice *d,
uint32_t address, uint32_t val, int len)
{
diff --git a/hw/pci.h b/hw/pci.h
index edc58b6..c2acab9 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -222,6 +222,11 @@ struct PCIDevice {
int irq_state[4];
};

+typedef struct {
+ PCIDevice dev;
+ PCIBus *bus;
+} PCIBridge;
+
extern char direct_pci_str[];
extern int direct_pci_msitranslate;
extern int direct_pci_power_mgmt;
diff --git a/hw/pt-graphics.c b/hw/pt-graphics.c
index c6f8869..de21f90 100644
--- a/hw/pt-graphics.c
+++ b/hw/pt-graphics.c
@@ -3,6 +3,7 @@
*/

#include "pass-through.h"
+#include "pci.h"
#include "pci/header.h"
#include "pci/pci.h"

@@ -40,9 +41,26 @@ void intel_pch_init(PCIBus *bus)
did = pt_pci_host_read(pci_dev_1f, PCI_DEVICE_ID, 2);
rid = pt_pci_host_read(pci_dev_1f, PCI_REVISION, 1);

- if ( vid == PCI_VENDOR_ID_INTEL )
- pci_bridge_init(bus, PCI_DEVFN(0x1f, 0), vid, did, rid,
- pch_map_irq, "intel_bridge_1f");
+ if (vid == PCI_VENDOR_ID_INTEL) {
+ PCIBridge *s = (PCIBridge *)pci_register_device(bus, "intel_bridge_1f",
+ sizeof(PCIBridge), PCI_DEVFN(0x1f, 0), NULL,
pci_bridge_write_config);
+
+ pci_config_set_vendor_id(s->dev.config, vid);
+ pci_config_set_device_id(s->dev.config, did);
+
+ s->dev.config[PCI_COMMAND] = 0x06; // command = bus master, pci mem
+ s->dev.config[PCI_COMMAND + 1] = 0x00;
+ s->dev.config[PCI_STATUS] = 0xa0; // status = fast
back-to-back, 66MHz, no error
+ s->dev.config[PCI_STATUS + 1] = 0x00; // status = fast devsel
+ s->dev.config[PCI_REVISION] = rid;
+ s->dev.config[PCI_CLASS_PROG] = 0x00; // programming i/f
+ pci_config_set_class(s->dev.config, PCI_CLASS_BRIDGE_ISA);
+ s->dev.config[PCI_LATENCY_TIMER] = 0x10;
+ s->dev.config[PCI_HEADER_TYPE] = 0x80;
+ s->dev.config[PCI_SEC_STATUS] = 0xa0;
+
+ s->bus = pci_register_secondary_bus(&s->dev, pch_map_irq);
+ }
}

uint32_t igd_read_opregion(struct pt_dev *pci_dev)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[PATCH] Correctly expose PCH ISA bridge for IGD passthrough (was PCI-PCI bridge) [ In reply to ]

firemeteor.guo at gmail

Dec 18, 2012, 7:33 AM

Post #2 of 4 (88 views)

Permalink

Hi Stefano,

Per your request, I resend your patch with my local modification to
fix the PCH ISA bridge to be exposed correctly to domU. This is XEN
part of the fix to make i915 driver properly detect the PCH version.
Another patch for i915 driver side is required too. I'll send that to
intel-gfx list separately. The combined patch set do fix the PCH
detection issue for me.

Thanks,
Timothy

diff --git a/hw/pci.c b/hw/pci.c
index f051de1..d371bd7 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -871,11 +871,6 @@ void pci_unplug_netifs(void)
}
}

-typedef struct {
- PCIDevice dev;
- PCIBus *bus;
-} PCIBridge;
-
void pci_bridge_write_config(PCIDevice *d,
uint32_t address, uint32_t val, int len)
{
diff --git a/hw/pci.h b/hw/pci.h
index edc58b6..c2acab9 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -222,6 +222,11 @@ struct PCIDevice {
int irq_state[4];
};

+typedef struct {
+ PCIDevice dev;
+ PCIBus *bus;
+} PCIBridge;
+
extern char direct_pci_str[];
extern int direct_pci_msitranslate;
extern int direct_pci_power_mgmt;
diff --git a/hw/pt-graphics.c b/hw/pt-graphics.c
index c6f8869..de21f90 100644
--- a/hw/pt-graphics.c
+++ b/hw/pt-graphics.c
@@ -3,6 +3,7 @@
*/

#include "pass-through.h"
+#include "pci.h"
#include "pci/header.h"
#include "pci/pci.h"

@@ -40,9 +41,26 @@ void intel_pch_init(PCIBus *bus)
did = pt_pci_host_read(pci_dev_1f, PCI_DEVICE_ID, 2);
rid = pt_pci_host_read(pci_dev_1f, PCI_REVISION, 1);

- if ( vid == PCI_VENDOR_ID_INTEL )
- pci_bridge_init(bus, PCI_DEVFN(0x1f, 0), vid, did, rid,
- pch_map_irq, "intel_bridge_1f");
+ if (vid == PCI_VENDOR_ID_INTEL) {
+ PCIBridge *s = (PCIBridge *)pci_register_device(bus, "intel_bridge_1f",
+ sizeof(PCIBridge), PCI_DEVFN(0x1f, 0), NULL,
pci_bridge_write_config);
+
+ pci_config_set_vendor_id(s->dev.config, vid);
+ pci_config_set_device_id(s->dev.config, did);
+
+ s->dev.config[PCI_COMMAND] = 0x06; // command = bus master, pci mem
+ s->dev.config[PCI_COMMAND + 1] = 0x00;
+ s->dev.config[PCI_STATUS] = 0xa0; // status = fast
back-to-back, 66MHz, no error
+ s->dev.config[PCI_STATUS + 1] = 0x00; // status = fast devsel
+ s->dev.config[PCI_REVISION] = rid;
+ s->dev.config[PCI_CLASS_PROG] = 0x00; // programming i/f
+ pci_config_set_class(s->dev.config, PCI_CLASS_BRIDGE_ISA);
+ s->dev.config[PCI_LATENCY_TIMER] = 0x10;
+ s->dev.config[PCI_HEADER_TYPE] = 0x80;
+ s->dev.config[PCI_SEC_STATUS] = 0xa0;
+
+ s->bus = pci_register_secondary_bus(&s->dev, pch_map_irq);
+ }
}

uint32_t igd_read_opregion(struct pt_dev *pci_dev)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Correctly expose PCH ISA bridge for IGD passthrough (was PCI-PCI bridge) [ In reply to ]

stefano.stabellini at eu

Dec 19, 2012, 3:47 AM

Post #3 of 4 (90 views)

Permalink

On Tue, 18 Dec 2012, G.R. wrote:
> Hi Stefano,
>
> Per your request, I resend your patch with my local modification to
> fix the PCH ISA bridge to be exposed correctly to domU. This is XEN
> part of the fix to make i915 driver properly detect the PCH version.
> Another patch for i915 driver side is required too. I'll send that to
> intel-gfx list separately. The combined patch set do fix the PCH
> detection issue for me.
>
> Thanks,
> Timothy

Thanks! The patch looks OK.
You need to write a proper description and add your signed-off-by as
well as mine.

http://wiki.xen.org/wiki/Submitting_Xen_Patches

> diff --git a/hw/pci.c b/hw/pci.c
> index f051de1..d371bd7 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -871,11 +871,6 @@ void pci_unplug_netifs(void)
> }
> }
>
> -typedef struct {
> - PCIDevice dev;
> - PCIBus *bus;
> -} PCIBridge;
> -
> void pci_bridge_write_config(
> PCIDevice *d,
> uint32_t address, uint32_t val, int len)
> {
> diff --git a/hw/pci.h b/hw/pci.h
> index edc58b6..c2acab9 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -222,6 +222,11 @@ struct PCIDevice {
> int irq_state[4];
> };
>
> +typedef struct {
> + PCIDevice dev;
> + PCIBus *bus;
> +} PCIBridge;
> +
> extern char direct_pci_str[];
> extern int direct_pci_msitranslate;
> extern int direct_pci_power_mgmt;
> diff --git a/hw/pt-graphics.c b/hw/pt-graphics.c
> index c6f8869..de21f90 100644
> --- a/hw/pt-graphics.c
> +++ b/hw/pt-graphics.c
> @@ -3,6 +3,7 @@
> */
>
> #include "pass-through.h"
> +#include "pci.h"
> #include "pci/header.h"
> #include "pci/pci.h"
>
> @@ -40,9 +41,26 @@ void intel_pch_init(PCIBus *bus)
> did = pt_pci_host_read(pci_dev_1f, PCI_DEVICE_ID, 2);
> rid = pt_pci_host_read(pci_dev_1f, PCI_REVISION, 1);
>
> - if ( vid == PCI_VENDOR_ID_INTEL )
> - pci_bridge_init(bus, PCI_DEVFN(0x1f, 0), vid, did, rid,
> - pch_map_irq, "intel_bridge_1f");
> + if (vid == PCI_VENDOR_ID_INTEL) {
> + PCIBridge *s = (PCIBridge *)pci_register_device(bus, "intel_bridge_1f",
> + sizeof(PCIBridge), PCI_DEVFN(0x1f, 0), NULL,
> pci_bridge_write_config);
> +
> + pci_config_set_vendor_id(s->dev.config, vid);
> + pci_config_set_device_id(s->dev.config, did);
> +
> + s->dev.config[PCI_COMMAND] = 0x06; // command = bus master, pci mem
> + s->dev.config[PCI_COMMAND + 1] = 0x00;
> + s->dev.config[PCI_STATUS] = 0xa0; // status = fast
> back-to-back, 66MHz, no error
> + s->dev.config[PCI_STATUS + 1] = 0x00; // status = fast devsel
> + s->dev.config[PCI_REVISION] = rid;
> + s->dev.config[PCI_CLASS_PROG] = 0x00; // programming i/f
> + pci_config_set_class(s->dev.config, PCI_CLASS_BRIDGE_ISA);
> + s->dev.config[PCI_LATENCY_TIMER] = 0x10;
> + s->dev.config[PCI_HEADER_TYPE] = 0x80;
> + s->dev.config[PCI_SEC_STATUS] = 0xa0;
> +
> + s->bus = pci_register_secondary_bus(&s->dev, pch_map_irq);
> + }
> }
>
> uint32_t igd_read_opregion(struct pt_dev *pci_dev)
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Correctly expose PCH ISA bridge for IGD passthrough (was PCI-PCI bridge) [ In reply to ]

firemeteor at users

Dec 19, 2012, 4:50 AM

Post #4 of 4 (83 views)

Permalink

On Wed, Dec 19, 2012 at 7:47 PM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Tue, 18 Dec 2012, G.R. wrote:
>> Hi Stefano,
>>
>> Per your request, I resend your patch with my local modification to
>> fix the PCH ISA bridge to be exposed correctly to domU. This is XEN
>> part of the fix to make i915 driver properly detect the PCH version.
>> Another patch for i915 driver side is required too. I'll send that to
>> intel-gfx list separately. The combined patch set do fix the PCH
>> detection issue for me.
>>
>> Thanks,
>> Timothy
>
> Thanks! The patch looks OK.
> You need to write a proper description and add your signed-off-by as
> well as mine.
>
> http://wiki.xen.org/wiki/Submitting_Xen_Patches
>
Thanks, I'll resend in a new thread.

>
>> diff --git a/hw/pci.c b/hw/pci.c
>> index f051de1..d371bd7 100644
>> --- a/hw/pci.c
>> +++ b/hw/pci.c
>> @@ -871,11 +871,6 @@ void pci_unplug_netifs(void)
>> }
>> }
>>
>> -typedef struct {
>> - PCIDevice dev;
>> - PCIBus *bus;
>> -} PCIBridge;
>> -
>> void pci_bridge_write_config(
>> PCIDevice *d,
>> uint32_t address, uint32_t val, int len)
>> {
>> diff --git a/hw/pci.h b/hw/pci.h
>> index edc58b6..c2acab9 100644
>> --- a/hw/pci.h
>> +++ b/hw/pci.h
>> @@ -222,6 +222,11 @@ struct PCIDevice {
>> int irq_state[4];
>> };
>>
>> +typedef struct {
>> + PCIDevice dev;
>> + PCIBus *bus;
>> +} PCIBridge;
>> +
>> extern char direct_pci_str[];
>> extern int direct_pci_msitranslate;
>> extern int direct_pci_power_mgmt;
>> diff --git a/hw/pt-graphics.c b/hw/pt-graphics.c
>> index c6f8869..de21f90 100644
>> --- a/hw/pt-graphics.c
>> +++ b/hw/pt-graphics.c
>> @@ -3,6 +3,7 @@
>> */
>>
>> #include "pass-through.h"
>> +#include "pci.h"
>> #include "pci/header.h"
>> #include "pci/pci.h"
>>
>> @@ -40,9 +41,26 @@ void intel_pch_init(PCIBus *bus)
>> did = pt_pci_host_read(pci_dev_1f, PCI_DEVICE_ID, 2);
>> rid = pt_pci_host_read(pci_dev_1f, PCI_REVISION, 1);
>>
>> - if ( vid == PCI_VENDOR_ID_INTEL )
>> - pci_bridge_init(bus, PCI_DEVFN(0x1f, 0), vid, did, rid,
>> - pch_map_irq, "intel_bridge_1f");
>> + if (vid == PCI_VENDOR_ID_INTEL) {
>> + PCIBridge *s = (PCIBridge *)pci_register_device(bus, "intel_bridge_1f",
>> + sizeof(PCIBridge), PCI_DEVFN(0x1f, 0), NULL,
>> pci_bridge_write_config);
>> +
>> + pci_config_set_vendor_id(s->dev.config, vid);
>> + pci_config_set_device_id(s->dev.config, did);
>> +
>> + s->dev.config[PCI_COMMAND] = 0x06; // command = bus master, pci mem
>> + s->dev.config[PCI_COMMAND + 1] = 0x00;
>> + s->dev.config[PCI_STATUS] = 0xa0; // status = fast
>> back-to-back, 66MHz, no error
>> + s->dev.config[PCI_STATUS + 1] = 0x00; // status = fast devsel
>> + s->dev.config[PCI_REVISION] = rid;
>> + s->dev.config[PCI_CLASS_PROG] = 0x00; // programming i/f
>> + pci_config_set_class(s->dev.config, PCI_CLASS_BRIDGE_ISA);
>> + s->dev.config[PCI_LATENCY_TIMER] = 0x10;
>> + s->dev.config[PCI_HEADER_TYPE] = 0x80;
>> + s->dev.config[PCI_SEC_STATUS] = 0xa0;
>> +
>> + s->bus = pci_register_secondary_bus(&s->dev, pch_map_irq);
>> + }
>> }
>>
>> uint32_t igd_read_opregion(struct pt_dev *pci_dev)
>>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel