Mailing List Archive: [PATCH 1/9] xen: arm: mark early

[PATCH 1/9] xen: arm: mark early_panic as a noreturn function

Dec 6, 2012, 5:10 AM

Post #1 of 3 (240 views)

Otherwise gcc complains about variables being used when not
initialised when in fact that point is never reached.

There aren't any instances of this in tree right now, I noticed this
while developing another patch.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/include/asm-arm/early_printk.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h
index f45f21e..a770d4a 100644
--- a/xen/include/asm-arm/early_printk.h
+++ b/xen/include/asm-arm/early_printk.h
@@ -15,7 +15,7 @@
#ifdef EARLY_UART_ADDRESS

void early_printk(const char *fmt, ...);
-void early_panic(const char *fmt, ...);
+void early_panic(const char *fmt, ...) __attribute__((noreturn));

#else

--
1.7.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH 1/9] xen: arm: mark early_panic as a noreturn function [ In reply to ]

tim at xen

Dec 13, 2012, 4:36 AM

Post #2 of 3 (237 views)

Permalink

At 13:10 +0000 on 06 Dec (1354799442), Ian Campbell wrote:
> Otherwise gcc complains about variables being used when not
> initialised when in fact that point is never reached.
>
> There aren't any instances of this in tree right now, I noticed this
> while developing another patch.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Tim Deegan <tim@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH 1/9] xen: arm: mark early_panic as a noreturn function [ In reply to ]

Ian.Campbell at citrix

Dec 19, 2012, 6:04 AM

Post #3 of 3 (231 views)

Permalink

On Thu, 2012-12-13 at 12:36 +0000, Tim Deegan wrote:
> At 13:10 +0000 on 06 Dec (1354799442), Ian Campbell wrote:
> > Otherwise gcc complains about variables being used when not
> > initialised when in fact that point is never reached.
> >
> > There aren't any instances of this in tree right now, I noticed this
> > while developing another patch.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Tim Deegan <tim@xen.org>

Applied, thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel