Mailing List Archive: [PATCH] xenballoond.init: remove 4 from default runlevel

[PATCH] xenballoond.init: remove 4 from default runlevel

Oct 5, 2012, 10:35 AM

Post #1 of 4 (364 views)

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1349458470 -7200
# Node ID 65ab6762cd37d0f43ff031e00637d5a88514aadb
# Parent 964fd4a693f940b5ae31d6d9021e0c89afaee703
xenballoond.init: remove 4 from default runlevel

Remove 4 from default runlevel in xenballoond.init.

Similar to what changeset 24847:0900b1c905f1 does in xencommons, remove
runlevel 4 from the other runlevel scripts. LSB defines runlevel 4 as
reserved for local use, the local sysadmin is responsible for symlink
creation in rc4.d.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 964fd4a693f9 -r 65ab6762cd37 tools/xenballoon/xenballoond.init
--- a/tools/xenballoon/xenballoond.init
+++ b/tools/xenballoon/xenballoond.init
@@ -14,7 +14,7 @@
# Should-Start:
# Required-Stop: $syslog $remote_fs
# Should-Stop:
-# Default-Start: 3 4 5
+# Default-Start: 3 5
# Default-Stop: 0 1 2 6
# Short-Description: Start/stop xenballoond
# Description: Starts and stops the Xen ballooning daemon.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] xenballoond.init: remove 4 from default runlevel [ In reply to ]

Ian.Campbell at citrix

Oct 8, 2012, 4:19 AM

Post #2 of 4 (346 views)

Permalink

On Fri, 2012-10-05 at 18:35 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1349458470 -7200
> # Node ID 65ab6762cd37d0f43ff031e00637d5a88514aadb
> # Parent 964fd4a693f940b5ae31d6d9021e0c89afaee703
> xenballoond.init: remove 4 from default runlevel
>
> Remove 4 from default runlevel in xenballoond.init.
>
> Similar to what changeset 24847:0900b1c905f1 does in xencommons, remove
> runlevel 4 from the other runlevel scripts. LSB defines runlevel 4 as
> reserved for local use, the local sysadmin is responsible for symlink
> creation in rc4.d.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked and applied, thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] xenballoond.init: remove 4 from default runlevel [ In reply to ]

dan.magenheimer at oracle

Oct 8, 2012, 12:48 PM

Post #3 of 4 (349 views)

Permalink

> From: Olaf Hering [mailto:olaf@aepfle.de]
> Subject: [Xen-devel] [PATCH] xenballoond.init: remove 4 from default runlevel
>
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1349458470 -7200
> # Node ID 65ab6762cd37d0f43ff031e00637d5a88514aadb
> # Parent 964fd4a693f940b5ae31d6d9021e0c89afaee703
> xenballoond.init: remove 4 from default runlevel
>
> Remove 4 from default runlevel in xenballoond.init.

Hi Olaf --

No objection to the patch, but I was wondering...

Are you using xenballoond for something? (e.g. your page-sharing
testing or a product implementation)

I stopped encouraging the use of userland selfballooning (which
is what xenballoond implements) years ago, when I saw
the impact of very sudden large workload increases...
thrashing can occur. This observation is what led to
tmem persistent pools and to selfballooning built into
the Linux kernel.

If you were just scanning Xen system services and ran across
this issue, no problem. But since it is somewhat related
to your page-sharing/host-swapping work, I thought I'd check.

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] xenballoond.init: remove 4 from default runlevel [ In reply to ]

olaf at aepfle

Oct 8, 2012, 2:13 PM

Post #4 of 4 (346 views)

Permalink

On Mon, Oct 08, Dan Magenheimer wrote:

> Are you using xenballoond for something? (e.g. your page-sharing
> testing or a product implementation)

No, its just a result from code review.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel