Mailing List Archive

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1319709256 -7200
# Node ID 2679263d65681e1e9f260bc1683eac1fa4ce2b66
# Parent 2423017c7ba57c9e0d91a061c4a28c06cee00d08
libxl: update prototype of libxl__spawn_check

libxl__spawn_check expects a malloc'd libxl__spawn_starting. The
currently only user of libxl__spawn_check gets a libxl__spawn_starting
and passes it on. Update prototype to not take a void pointer, and also
update comment in header file.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 2423017c7ba5 -r 2679263d6568 tools/libxl/libxl_exec.c
--- a/tools/libxl/libxl_exec.c
+++ b/tools/libxl/libxl_exec.c
@@ -431,10 +431,9 @@ int libxl__spawn_detach(libxl__gc *gc,
return rc;
}

-int libxl__spawn_check(libxl__gc *gc, void *for_spawn_void)
+int libxl__spawn_check(libxl__gc *gc, libxl__spawn_starting *for_spawn)
{
libxl_ctx *ctx = libxl__gc_owner(gc);
- libxl__spawn_starting *for_spawn = for_spawn_void;
pid_t got;
int status;

diff -r 2423017c7ba5 -r 2679263d6568 tools/libxl/libxl_internal.h
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -385,12 +385,10 @@ _hidden int libxl__spawn_detach(libxl__g
* Returns 0 on success, and < 0 on error.
*
* Logs errors but also returns them.
- * for_spawn must actually be a libxl__spawn_starting* but
- * we take void* so you can pass this function directly to
- * libxl__wait_for_offspring. Caller must still call detach.
+ * Caller must still call detach.
*/
_hidden int libxl__spawn_check(libxl__gc *gc,
- void *for_spawn);
+ libxl__spawn_starting *for_spawn);

/* low-level stuff, for synchronous subprocesses etc. */


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel