Mailing List Archive: [PATCH 01 of 27 v3] libxl: add missing "break; " to do_pci

[PATCH 01 of 27 v3] libxl: add missing "break; " to do_pci_remove

Oct 18, 2011, 5:54 AM

Post #1 of 3 (142 views)

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1318930552 -3600
# Node ID e03520648d2c91210d59a90f497b356fd72eb36f
# Parent 955a6c07dc5e9c55316d1678b2b7cc4313f4fd57
libxl: add missing "break;" to do_pci_remove

Otherwise we erroneously fall through the LIBXL_DOMAIN_TYPE_PV case into the
"default: abort()".

(I'm sure we fixed this once already...)

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r 955a6c07dc5e -r e03520648d2c tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c Tue Oct 18 10:33:32 2011 +0100
+++ b/tools/libxl/libxl_pci.c Tue Oct 18 10:35:52 2011 +0100
@@ -930,6 +930,7 @@ skip1:
}
}
fclose(f);
+ break;
}
default:
abort();

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 01 of 27 v3] libxl: add missing "break; " to do_pci_remove [ In reply to ]

raistlin at linux

Oct 19, 2011, 9:14 AM

Post #2 of 3 (131 views)

Permalink

On Tue, Oct 18, 2011 at 2:54 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1318930552 -3600
> # Node ID e03520648d2c91210d59a90f497b356fd72eb36f
> # Parent 955a6c07dc5e9c55316d1678b2b7cc4313f4fd57
> libxl: add missing "break;" to do_pci_remove
>
> Otherwise we erroneously fall through the LIBXL_DOMAIN_TYPE_PV case into the
> "default: abort()".
>
> (I'm sure we fixed this once already...)
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
Tested-by: Dario Faggioli <dario.faggioli@citrix.com>

--
<<This happens because I choose it to happen!>> (Raistlin Majere)
----------------------------------------------------------------------
Dario Faggioli, <http://retis.sssup.it/people/faggioli>
PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)
Senior Software Engineer, Citrix Systems R&D, Cambridge (UK)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 01 of 27 v3] libxl: add missing "break; " to do_pci_remove [ In reply to ]

Ian.Jackson at eu

Oct 25, 2011, 9:04 AM

Post #3 of 3 (125 views)

Permalink

Dario Faggioli writes ("Re: [Xen-devel] [PATCH 01 of 27 v3] libxl: add missing "break; " to do_pci_remove"):
> On Tue, Oct 18, 2011 at 2:54 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> > libxl: add missing "break;" to do_pci_remove
...
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >
> Tested-by: Dario Faggioli <dario.faggioli@citrix.com>

Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel