Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Xen>
  3. Devel
[PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect
marmarek at mimuw
May 2, 2011, 4:06 AM
Post #1 of 5 (188 views)
Permalink
barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code -
drivers/xen/blkfront/blkfront.c). The later caused incorrect device
flags (RO/removable etc).

Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>
---
drivers/block/xen-blkfront.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 70f3b1b..6147a4e 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
*info)
}

err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
- "feature-barrier", "%lu", &barrier,
+ "feature-barrier", "%d", &barrier,
NULL);

/*

Attached Files:

Re: [PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect [ In reply to ]
Ian.Campbell at citrix
May 3, 2011, 5:58 AM
Post #2 of 5 (174 views)
Permalink
On Mon, 2011-05-02 at 12:06 +0100, Marek Marczykowski wrote:
> barrier variable is int, not long. This overflow caused another variable
> override: "err" (in PV code) and "binfo" (in xenlinux code -
> drivers/xen/blkfront/blkfront.c). The later caused incorrect device
> flags (RO/removable etc).
>
> Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>

Good catch.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
> drivers/block/xen-blkfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 70f3b1b..6147a4e 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
> *info)
> }
>
> err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> - "feature-barrier", "%lu", &barrier,
> + "feature-barrier", "%d", &barrier,
> NULL);
>
> /*
>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: [PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect [ In reply to ]
konrad.wilk at oracle
May 3, 2011, 8:40 AM
Post #3 of 5 (183 views)
Permalink
On Mon, May 02, 2011 at 01:06:19PM +0200, Marek Marczykowski wrote:
> barrier variable is int, not long. This overflow caused another variable
> override: "err" (in PV code) and "binfo" (in xenlinux code -
> drivers/xen/blkfront/blkfront.c). The later caused incorrect device
> flags (RO/removable etc).

Weird, I get this:

konrad@phenom:~/work/linux$ patch -p1 < ~/for-40-blkfront
patching file drivers/block/xen-blkfront.c
patch: **** malformed patch at line 124: *info)

Any ideas? Can you send the patch as attachment please?
>
> Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>
> ---
> drivers/block/xen-blkfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 70f3b1b..6147a4e 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
> *info)
> }
>
> err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> - "feature-barrier", "%lu", &barrier,
> + "feature-barrier", "%d", &barrier,
> NULL);
>
> /*
>



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: [PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect [ In reply to ]
Ian.Campbell at citrix
May 3, 2011, 8:43 AM
Post #4 of 5 (176 views)
Permalink
On Tue, 2011-05-03 at 16:40 +0100, Konrad Rzeszutek Wilk wrote:
> On Mon, May 02, 2011 at 01:06:19PM +0200, Marek Marczykowski wrote:
> > barrier variable is int, not long. This overflow caused another variable
> > override: "err" (in PV code) and "binfo" (in xenlinux code -
> > drivers/xen/blkfront/blkfront.c). The later caused incorrect device
> > flags (RO/removable etc).
>
> Weird, I get this:
>
> konrad@phenom:~/work/linux$ patch -p1 < ~/for-40-blkfront
> patching file drivers/block/xen-blkfront.c
> patch: **** malformed patch at line 124: *info)
>
> Any ideas? Can you send the patch as attachment please?
> >
> > Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>
> > ---
> > drivers/block/xen-blkfront.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> > index 70f3b1b..6147a4e 100644
> > --- a/drivers/block/xen-blkfront.c
> > +++ b/drivers/block/xen-blkfront.c
> > @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
> > *info)

^ the original path was lined wrapped in at least this spot

> > }
> >
> > err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> > - "feature-barrier", "%lu", &barrier,
> > + "feature-barrier", "%d", &barrier,
> > NULL);
> >
> > /*
> >
>
>
>
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Re: [PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect [ In reply to ]
marmarek at mimuw
May 3, 2011, 8:43 AM
Post #5 of 5 (179 views)
Permalink
On 03.05.2011 17:40, Konrad Rzeszutek Wilk wrote:
> On Mon, May 02, 2011 at 01:06:19PM +0200, Marek Marczykowski wrote:
>> barrier variable is int, not long. This overflow caused another variable
>> override: "err" (in PV code) and "binfo" (in xenlinux code -
>> drivers/xen/blkfront/blkfront.c). The later caused incorrect device
>> flags (RO/removable etc).
>
> Weird, I get this:
>
> konrad@phenom:~/work/linux$ patch -p1 < ~/for-40-blkfront
> patching file drivers/block/xen-blkfront.c
> patch: **** malformed patch at line 124: *info)
>
> Any ideas?

Ehh... my email client wrapped this line...

> Can you send the patch as attachment please?

Sure, attached.

>> Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>
>> ---
>> drivers/block/xen-blkfront.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index 70f3b1b..6147a4e 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
>> *info)
>> }
>>
>> err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
>> - "feature-barrier", "%lu", &barrier,
>> + "feature-barrier", "%d", &barrier,
>> NULL);
>>
>> /*
>>
>
>
>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>


--
Pozdrawiam / Best Regards,
Marek Marczykowski | RLU #390519
marmarek at mimuw edu pl | xmpp:marmarek at staszic waw pl

Attached Files:

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal