Mailing List Archive

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1268157181 0
# Node ID bfaafdddf31a1c3988a7bb39a045f950e38a8cbf
# Parent 5f08fd0d6249ed9522b9cdf6e928210da5739dab
tmem: typo causes incorrect return on out-of-memory

This classic typo in tmem would result in a false positive
report on a tmem "put" operation if a (unfragmented) page
of memory is completely unavailable.

Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
---
xen/common/tmem.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 5f08fd0d6249 -r bfaafdddf31a xen/common/tmem.c
--- a/xen/common/tmem.c Tue Mar 09 12:34:39 2010 +0000
+++ b/xen/common/tmem.c Tue Mar 09 17:53:01 2010 +0000
@@ -1308,7 +1308,7 @@ copy_uncompressed:
copy_uncompressed:
if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL )
{
- ret == -ENOMEM;
+ ret = -ENOMEM;
goto delete_and_free;
}
/* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog