Mailing List Archive

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1227008583 0
# Node ID 9cf32a0f8233d5bf6c35f1cdd10758416cd40207
# Parent c13f04a8b6a1458f8c01f814d08f31080bd38276
x86, vmx realmode: Stack manipulation on interrupt/exception injection
should respect SS size, not CS size.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen-unstable changeset: 18761:832efb028a1dc72fb52edc11c958fd19f8542e48
xen-unstable date: Fri Nov 07 17:06:21 2008 +0000

vmx: Fix realmode exception delivery to correctly check stack pointer size.

Bug tracked down by Tim Deegan <tim.deegan@citrix.com>

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen-unstable changeset: 18766:92d0e13b0ea365f019116450910bb0f3819c109c
xen-unstable date: Tue Nov 11 11:10:59 2008 +0000
---
xen/arch/x86/hvm/vmx/realmode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)

diff -r c13f04a8b6a1 -r 9cf32a0f8233 xen/arch/x86/hvm/vmx/realmode.c
--- a/xen/arch/x86/hvm/vmx/realmode.c Tue Nov 18 11:39:30 2008 +0000
+++ b/xen/arch/x86/hvm/vmx/realmode.c Tue Nov 18 11:43:03 2008 +0000
@@ -90,7 +90,8 @@ static void realmode_deliver_exception(
frame[1] = csr->sel;
frame[2] = regs->eflags & ~X86_EFLAGS_RF;

- if ( rm_ctxt->ctxt.addr_size == 32 )
+ /* We can't test rm_ctxt->ctxt.sp_size: it may not be initialised. */
+ if ( rm_ctxt->seg_reg[x86_seg_ss].attr.fields.db )
{
regs->esp -= 6;
pstk = regs->esp;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xensource.com
http://lists.xensource.com/xen-changelog