Mailing List Archive

Minor updates
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've checked in a few quick tweaks to cvs, just fyi:
* wfCheckLimits() function factors out some of the
$offset/$limit-checking common to a lot of special pages
* some old str_replace("$1"...wfMsg()) sequences replaced with
wfMsg("...","...")
* Preliminary support for mysql4 fulltext boolean mode search (not done
yet: need to split up terms for highlighting and make sure intl
conversion is done)
* Very preliminary patches for adding license fields to the image table.
Not even checked for syntax, and not supported by any code yet.

Just a quick though also: it _would_ be nice to be able to search for eg
"C++" or "C#". Mysql's fulltext search I don't think will preserve
these, but in theory we can armor them the same way we do for utf-8
high characters.

Also: http://www.mysql.com/doc/en/Fulltext_Search.html
scroll down for the boolean mode notes. For people used to google-style
searches (or our current search method), the default behavior being
'or' instead of 'and' may be confusing. We could force adding +s to the
search terms to change the behavior, but this could be tricky to do
right, and we'd probably want a way to undo it.

Also, the phrase search ("foo bar") may be problematic with our handling
of links, where "biz [[foo|bar]] bax" is indexed as "biz foo bar bax"
and "biz [[foo]]bar bax" as "biz foo foobar bax" or some such.

Current cvs running on test.wikipedia.org.

- -- brion vibber (brion @ pobox.com)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+3GPCxVlOmwh1xjgRAuYGAJ9lDX+2p/6REcR9g1gdEvBX2RJa8ACfaqXa
59p1jUPRkaRCmQ5Y5qkEJ3I=
=LMY8
-----END PGP SIGNATURE-----
Re: Minor updates [ In reply to ]
>I've checked in a few quick tweaks to cvs, just fyi:

I thought there was meant to be a feature freeze on. I've got major changes
pending to SpecialRecenchanges and SpecialRecentchangeslinked, so don't go
changing them. I've also got minor (i.e. easily merged) changes pending to
GlobalFunctions and Language.php.

The changes to SpecialRecentchanges don't look big to the user: now you can
hide minor edits without going to the user preferences (that's really a bug
fix more than anything), and you can hide edits by logged in users. But the
increased complexity incited me to revamp the code somewhat.

-- Tim Starling

_________________________________________________________________
Get mobile Hotmail. Go to http://ninemsn.com.au/mobilecentral/signup.asp
Re: Minor updates [ In reply to ]
On Wed, 4 Jun 2003, Tim Starling wrote:
> >I've checked in a few quick tweaks to cvs, just fyi:
>
> I thought there was meant to be a feature freeze on.

There was supposed to be a feature freeze for Lee to upgrade everything
last weekend. I'm not sure what happened there, I assume Lee is swamped
with real life like the rest of us. :)

But anyway, these are bug fixes, not features. The search code changes (to
fix problems with our existing boolean search) is still disabled by
default, there are no code changes yet for image tables, and the
limit/offset consolidation helps protect against possible sql/xss
insertion attacks with better validation (forcing the values to integers
before dumping them into SQL queries or HTML output).

> I've got major changes
> pending to SpecialRecenchanges and SpecialRecentchangeslinked, so don't go
> changing them. I've also got minor (i.e. easily merged) changes pending to
> GlobalFunctions and Language.php.
>
> The changes to SpecialRecentchanges don't look big to the user: now you can
> hide minor edits without going to the user preferences (that's really a bug
> fix more than anything), and you can hide edits by logged in users. But the
> increased complexity incited me to revamp the code somewhat.

Looking forward to it...

-- brion vibber (brion @ pobox.com)
Re: Minor updates [ In reply to ]
> (Brion Vibber <vibber@aludra.usc.edu>):
> There was supposed to be a feature freeze for Lee to upgrade everything
> last weekend. I'm not sure what happened there, I assume Lee is swamped
> with real life like the rest of us. :)

That's a pretty fair assumption. I _really_ want to get at least
the English wiki in sync with CVS before we start doing major surgery,
and preferably more of them.

--
Lee Daniel Crocker <lee@piclab.com> <http://www.piclab.com/lee/>
"All inventions or works of authorship original to me, herein and past,
are placed irrevocably in the public domain, and may be used or modified
for any purpose, without permission, attribution, or notification."--LDC