Mailing List Archive

Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406119 )

Change subject: Remove some backwards-compatibility in tests
......................................................................

Remove some backwards-compatibility in tests

Change-Id: I1d3f5a838952c246af7491e355d65714f58a5e62
---
M tests/phpunit/ApiPageTriageActionTest.php
M tests/phpunit/SpecialNewPagesFeedTest.php
2 files changed, 3 insertions(+), 6 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage refs/changes/19/406119/1

diff --git a/tests/phpunit/ApiPageTriageActionTest.php b/tests/phpunit/ApiPageTriageActionTest.php
index 12c04df..9c65506 100644
--- a/tests/phpunit/ApiPageTriageActionTest.php
+++ b/tests/phpunit/ApiPageTriageActionTest.php
@@ -17,16 +17,14 @@
function setUp() {
parent::setUp();

- $testUserClass = class_exists( 'ApiTestUser' ) ? 'ApiTestUser' : 'TestUser';
-
- self::$users['one'] = new $testUserClass(
+ self::$users['one'] = new TestUser(
'ApitestuserA',
'Api Test UserA',
'api_test_userA@example.com',
[ 'sysop' ]
);

- self::$users['two'] = new $testUserClass(
+ self::$users['two'] = new TestUser(
'ApitestuserB',
'Api Test UserB',
'api_test_userB@example.com',
diff --git a/tests/phpunit/SpecialNewPagesFeedTest.php b/tests/phpunit/SpecialNewPagesFeedTest.php
index 828402e..102716b 100644
--- a/tests/phpunit/SpecialNewPagesFeedTest.php
+++ b/tests/phpunit/SpecialNewPagesFeedTest.php
@@ -17,8 +17,7 @@
public static $users;

public function setUp() {
- $testUserClass = class_exists( 'ApiTestUser' ) ? 'ApiTestUser' : 'TestUser';
- self::$users['one'] = new $testUserClass(
+ self::$users['one'] = new TestUser(
'PageTriageUser1',
'PageTriage Test User 1',
'pagetriage_test_user_1@example.com',

--
To view, visit https://gerrit.wikimedia.org/r/406119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d3f5a838952c246af7491e355d65714f58a5e62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm@member.fsf.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits