Mailing List Archive

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406039 )

Change subject: Don't cache when sql model lookup returns empty
......................................................................


Don't cache when sql model lookup returns empty

Bug: T184938
Change-Id: If744f0ea35cc62e8cb1b85d134519e2bf257b872
---
M includes/Storage/SqlModelLookup.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved



diff --git a/includes/Storage/SqlModelLookup.php b/includes/Storage/SqlModelLookup.php
index d17f0e3..884a158 100644
--- a/includes/Storage/SqlModelLookup.php
+++ b/includes/Storage/SqlModelLookup.php
@@ -71,7 +71,7 @@
}

private function getModelData() {
- if ( $this->modelData === null ) {
+ if ( $this->modelData === null || $this->modelData === [] ) {
$this->modelData = [];
$result = $this->loadBalancer->getConnection( DB_REPLICA )->select(
'ores_model',

--
To view, visit https://gerrit.wikimedia.org/r/406039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If744f0ea35cc62e8cb1b85d134519e2bf257b872
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <Ladsgroup@gmail.com>
Gerrit-Reviewer: Awight <awight@wikimedia.org>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits