Mailing List Archive

Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406014 )

Change subject: Follow-up 6bb7939a79: use GenderCache
......................................................................

Follow-up 6bb7939a79: use GenderCache

Change-Id: I7511af52822ca2c99e08cf04cd07c880959325b4
---
M Thanks.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks refs/changes/14/406014/1

diff --git a/Thanks.hooks.php b/Thanks.hooks.php
index e325d98..376018a 100644
--- a/Thanks.hooks.php
+++ b/Thanks.hooks.php
@@ -101,6 +101,7 @@
);
}

+ $genderCache = MediaWikiServices::getInstance()->getGenderCache();
// Add 'thank' link
$tooltip = wfMessage( 'thanks-thank-tooltip' )
->params( $wgUser->getName(), $recipient->getName() )
@@ -113,7 +114,7 @@
'href' => SpecialPage::getTitleFor( 'Thanks', $rev->getId() )->getFullURL(),
'title' => $tooltip,
'data-revision-id' => $rev->getId(),
- 'data-recipient-gender' => $recipient->getOption( 'gender' ) ?: 'unknown',
+ 'data-recipient-gender' => $genderCache->getGenderOf( $recipient->getName(), __METHOD__ ),
],
wfMessage( 'thanks-thank', $wgUser, $recipient->getName() )->text()
);

--
To view, visit https://gerrit.wikimedia.org/r/406014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7511af52822ca2c99e08cf04cd07c880959325b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits