Mailing List Archive

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406013 )

Change subject: CommentNode: Protect against call after teardown
......................................................................


CommentNode: Protect against call after teardown

Change-Id: I276cc64e522556f482f9fc7d0bb43f32d521defa
---
M src/ce/nodes/ve.ce.CommentNode.js
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
Divec: Looks good to me, approved
jenkins-bot: Verified



diff --git a/src/ce/nodes/ve.ce.CommentNode.js b/src/ce/nodes/ve.ce.CommentNode.js
index 210a931..a2030e3 100644
--- a/src/ce/nodes/ve.ce.CommentNode.js
+++ b/src/ce/nodes/ve.ce.CommentNode.js
@@ -95,7 +95,13 @@
* @inheritdoc
*/
ve.ce.CommentNode.prototype.createInvisibleIcon = function () {
- var icon = new OO.ui.ButtonWidget( {
+ var icon;
+ // Check the node hasn't been destroyed, as this method is
+ // called after an rAF in ve.ce.FocusableNode
+ if ( !this.getModel() ) {
+ return;
+ }
+ icon = new OO.ui.ButtonWidget( {
classes: [ 've-ce-focusableNode-invisibleIcon' ],
framed: false,
icon: this.constructor.static.iconWhenInvisible,

--
To view, visit https://gerrit.wikimedia.org/r/406013
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I276cc64e522556f482f9fc7d0bb43f32d521defa
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esanders@wikimedia.org>
Gerrit-Reviewer: Divec <david@troi.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits