Mailing List Archive

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make Default list sticky, regardless of sorting.
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405917 )

Change subject: Make Default list sticky, regardless of sorting.
......................................................................

Make Default list sticky, regardless of sorting.

Change-Id: I9b70809192d3f67f51edd2ae20c0a69a8784719f
---
M app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
1 file changed, 12 insertions(+), 0 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/17/405917/1

diff --git a/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java b/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
index 4a93581..eeb7818 100644
--- a/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
+++ b/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
@@ -159,5 +159,17 @@
default:
break;
}
+ // make the Default list sticky on top, regardless of sorting.
+ ReadingList defaultList = null;
+ for (ReadingList list : lists) {
+ if (list.isDefault()) {
+ defaultList = list;
+ break;
+ }
+ }
+ if (defaultList != null) {
+ lists.remove(defaultList);
+ lists.add(0, defaultList);
+ }
}
}

--
To view, visit https://gerrit.wikimedia.org/r/405917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b70809192d3f67f51edd2ae20c0a69a8784719f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbrant@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make Default list sticky, regardless of sorting. [ In reply to ]
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405917 )

Change subject: Make Default list sticky, regardless of sorting.
......................................................................


Make Default list sticky, regardless of sorting.

Change-Id: I9b70809192d3f67f51edd2ae20c0a69a8784719f
---
M app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
jenkins-bot: Verified
Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java b/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
index 4a93581..eeb7818 100644
--- a/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
+++ b/app/src/main/java/org/wikipedia/readinglist/database/ReadingList.java
@@ -159,5 +159,17 @@
default:
break;
}
+ // make the Default list sticky on top, regardless of sorting.
+ ReadingList defaultList = null;
+ for (ReadingList list : lists) {
+ if (list.isDefault()) {
+ defaultList = list;
+ break;
+ }
+ }
+ if (defaultList != null) {
+ lists.remove(defaultList);
+ lists.add(0, defaultList);
+ }
}
}

--
To view, visit https://gerrit.wikimedia.org/r/405917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b70809192d3f67f51edd2ae20c0a69a8784719f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbrant@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <brion@wikimedia.org>
Gerrit-Reviewer: Cooltey <cfeng@wikimedia.org>
Gerrit-Reviewer: Sharvaniharan <sharan@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits