Mailing List Archive

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update red background color when swiping to delete.
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405837 )

Change subject: Update red background color when swiping to delete.
......................................................................

Update red background color when swiping to delete.

Bug: T185539
Change-Id: Iab192bb0765fd1b076d6dc7e543e060e4cadd824
---
M app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
1 file changed, 2 insertions(+), 2 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/37/405837/1

diff --git a/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java b/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
index 4e586f5..9ddefa9 100644
--- a/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
+++ b/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
@@ -3,9 +3,9 @@
import android.content.Context;
import android.graphics.Bitmap;
import android.graphics.Canvas;
-import android.graphics.Color;
import android.graphics.Paint;
import android.support.annotation.NonNull;
+import android.support.v4.content.ContextCompat;
import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.helper.ItemTouchHelper;

@@ -26,7 +26,7 @@

public SwipeableItemTouchHelperCallback(@NonNull Context context) {
deleteBackgroundPaint.setStyle(Paint.Style.FILL);
- deleteBackgroundPaint.setColor(Color.RED);
+ deleteBackgroundPaint.setColor(ContextCompat.getColor(context, R.color.red50));
itemBackgroundPaint.setStyle(Paint.Style.FILL);
itemBackgroundPaint.setColor(ResourceUtil.getThemedColor(context, android.R.attr.windowBackground));
deleteIcon = ResourceUtil.bitmapFromVectorDrawable(context, R.drawable.ic_delete_white_24dp);

--
To view, visit https://gerrit.wikimedia.org/r/405837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab192bb0765fd1b076d6dc7e543e060e4cadd824
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbrant@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update red background color when swiping to delete. [ In reply to ]
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405837 )

Change subject: Update red background color when swiping to delete.
......................................................................


Update red background color when swiping to delete.

Bug: T185539
Change-Id: Iab192bb0765fd1b076d6dc7e543e060e4cadd824
---
M app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
Sharvaniharan: Looks good to me, approved
jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java b/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
index 4e586f5..9ddefa9 100644
--- a/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
+++ b/app/src/main/java/org/wikipedia/views/SwipeableItemTouchHelperCallback.java
@@ -3,9 +3,9 @@
import android.content.Context;
import android.graphics.Bitmap;
import android.graphics.Canvas;
-import android.graphics.Color;
import android.graphics.Paint;
import android.support.annotation.NonNull;
+import android.support.v4.content.ContextCompat;
import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.helper.ItemTouchHelper;

@@ -26,7 +26,7 @@

public SwipeableItemTouchHelperCallback(@NonNull Context context) {
deleteBackgroundPaint.setStyle(Paint.Style.FILL);
- deleteBackgroundPaint.setColor(Color.RED);
+ deleteBackgroundPaint.setColor(ContextCompat.getColor(context, R.color.red50));
itemBackgroundPaint.setStyle(Paint.Style.FILL);
itemBackgroundPaint.setColor(ResourceUtil.getThemedColor(context, android.R.attr.windowBackground));
deleteIcon = ResourceUtil.bitmapFromVectorDrawable(context, R.drawable.ic_delete_white_24dp);

--
To view, visit https://gerrit.wikimedia.org/r/405837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab192bb0765fd1b076d6dc7e543e060e4cadd824
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbrant@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <brion@wikimedia.org>
Gerrit-Reviewer: Cooltey <cfeng@wikimedia.org>
Gerrit-Reviewer: Sharvaniharan <sharan@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits