Mailing List Archive

[MediaWiki-commits] [Gerrit] performance/WebPageTest[master]: Collect FirstInteractive and TimeToInteractive.
Phedenskog has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405693 )

Change subject: Collect FirstInteractive and TimeToInteractive.
......................................................................

Collect FirstInteractive and TimeToInteractive.

When we move to the Linux agents (or new version of WPT) the
FirstInteractive and TimeToInteractive will be availible.

When we push the new agent we can also update the test.json
files so it includes all the new metrics.

Bug: T115606
Change-Id: Ie4049750347a270748ae39c4ca366c26a0d977f8
---
M lib/cli.js
1 file changed, 1 insertion(+), 2 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/performance/WebPageTest refs/changes/93/405693/1

diff --git a/lib/cli.js b/lib/cli.js
index 56bd37c..d7b0e96 100644
--- a/lib/cli.js
+++ b/lib/cli.js
@@ -21,8 +21,7 @@
// #TOC-Sample
// Not 100% sure it's the latest though. Test by logging the output from WebPageTest
// Note: It can differ depending on what agent that runs the tests.
-// In the future we can add LastInteractive = TTI but it only works in Chrome
-const DEFAULT_METRICS = 'SpeedIndex,render,TTFB,fullyLoaded,lastVisualChange,visualComplete95,visualComplete99,LastInteractive';
+const DEFAULT_METRICS = 'SpeedIndex,render,TTFB,fullyLoaded,lastVisualChange,visualComplete95,visualComplete99,FirstInteractive,TimeToInteractive,LastInteractive';

module.exports = {
/**

--
To view, visit https://gerrit.wikimedia.org/r/405693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4049750347a270748ae39c4ca366c26a0d977f8
Gerrit-PatchSet: 1
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedenskog@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] performance/WebPageTest[master]: Collect FirstInteractive and TimeToInteractive. [ In reply to ]
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405693 )

Change subject: Collect FirstInteractive and TimeToInteractive.
......................................................................


Collect FirstInteractive and TimeToInteractive.

When we move to the Linux agents (or new version of WPT) the
FirstInteractive and TimeToInteractive will be availible.

When we push the new agent we can also update the test.json
files so it includes all the new metrics.

Bug: T115606
Change-Id: Ie4049750347a270748ae39c4ca366c26a0d977f8
---
M lib/cli.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
Gilles: Looks good to me, but someone else must approve



diff --git a/lib/cli.js b/lib/cli.js
index 56bd37c..d7b0e96 100644
--- a/lib/cli.js
+++ b/lib/cli.js
@@ -21,8 +21,7 @@
// #TOC-Sample
// Not 100% sure it's the latest though. Test by logging the output from WebPageTest
// Note: It can differ depending on what agent that runs the tests.
-// In the future we can add LastInteractive = TTI but it only works in Chrome
-const DEFAULT_METRICS = 'SpeedIndex,render,TTFB,fullyLoaded,lastVisualChange,visualComplete95,visualComplete99,LastInteractive';
+const DEFAULT_METRICS = 'SpeedIndex,render,TTFB,fullyLoaded,lastVisualChange,visualComplete95,visualComplete99,FirstInteractive,TimeToInteractive,LastInteractive';

module.exports = {
/**

--
To view, visit https://gerrit.wikimedia.org/r/405693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4049750347a270748ae39c4ca366c26a0d977f8
Gerrit-PatchSet: 1
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedenskog@wikimedia.org>
Gerrit-Reviewer: Gilles <gdubuc@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklemail@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits