Mailing List Archive

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: Lower caching length on doc.wikimedia.org
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403401 )

Change subject: contint: Lower caching length on doc.wikimedia.org
......................................................................

contint: Lower caching length on doc.wikimedia.org

These files are auto-generated and published by Jenkins, but often older
versions remain cached by varnish.

Apache will now send a Cache-Control header to tell varnish to only cache the
content for an hour. Since these are mostly static HTML/JS/CSS with a few PHP
scripts, there shouldn't be a performance impact.

Bug: T184255
Change-Id: I4092bb26007cba53157d29557fc1902fd746c055
---
M modules/contint/templates/apache/doc.wikimedia.org.erb
1 file changed, 3 insertions(+), 0 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/01/403401/1

diff --git a/modules/contint/templates/apache/doc.wikimedia.org.erb b/modules/contint/templates/apache/doc.wikimedia.org.erb
index 889e3ea..d811431 100644
--- a/modules/contint/templates/apache/doc.wikimedia.org.erb
+++ b/modules/contint/templates/apache/doc.wikimedia.org.erb
@@ -20,6 +20,9 @@
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^(.+[^/])$ https://doc.wikimedia.org/$1/ [R=301,QSA]

+ # Lower caching length (T184255)
+ Header set Cache-Control "s-maxage=3600, must-revalidate, max-age=0"
+
# Back-compat for T73060: Redirect mediawiki-core/master/php/html/ to mediawiki-core/master/php/
RewriteRule ^mediawiki-core/master/php/html/(.*)$ https://doc.wikimedia.org/mediawiki-core/master/php/$1 [L,QSA]


--
To view, visit https://gerrit.wikimedia.org/r/403401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4092bb26007cba53157d29557fc1902fd746c055
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Legoktm <legoktm@member.fsf.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: Lower caching length on doc.wikimedia.org [ In reply to ]
Giuseppe Lavagetto has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403401 )

Change subject: contint: Lower caching length on doc.wikimedia.org
......................................................................


contint: Lower caching length on doc.wikimedia.org

These files are auto-generated and published by Jenkins, but often older
versions remain cached by varnish.

Apache will now send a Cache-Control header to tell varnish to only cache the
content for an hour. Since these are mostly static HTML/JS/CSS with a few PHP
scripts, there shouldn't be a performance impact.

Bug: T184255
Change-Id: I4092bb26007cba53157d29557fc1902fd746c055
---
M modules/contint/templates/apache/doc.wikimedia.org.erb
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
Giuseppe Lavagetto: Looks good to me, approved
Ema: Looks good to me, but someone else must approve
Hashar: Looks good to me, but someone else must approve
jenkins-bot: Verified



diff --git a/modules/contint/templates/apache/doc.wikimedia.org.erb b/modules/contint/templates/apache/doc.wikimedia.org.erb
index 889e3ea..d811431 100644
--- a/modules/contint/templates/apache/doc.wikimedia.org.erb
+++ b/modules/contint/templates/apache/doc.wikimedia.org.erb
@@ -20,6 +20,9 @@
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^(.+[^/])$ https://doc.wikimedia.org/$1/ [R=301,QSA]

+ # Lower caching length (T184255)
+ Header set Cache-Control "s-maxage=3600, must-revalidate, max-age=0"
+
# Back-compat for T73060: Redirect mediawiki-core/master/php/html/ to mediawiki-core/master/php/
RewriteRule ^mediawiki-core/master/php/html/(.*)$ https://doc.wikimedia.org/mediawiki-core/master/php/$1 [L,QSA]


--
To view, visit https://gerrit.wikimedia.org/r/403401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4092bb26007cba53157d29557fc1902fd746c055
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Legoktm <legoktm@member.fsf.org>
Gerrit-Reviewer: Ema <ema@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavagetto@wikimedia.org>
Gerrit-Reviewer: Hashar <hashar@free.fr>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits