Mailing List Archive

On Thu, Apr 26, 2012 at 4:48 AM, Marcelo Moreira <marceloddm@gmail.com> wrote:
> Hi,
>
> I have made a patch to version 0.5.3 to add support to configure the
> interface MAC address (for the case when a TAP interface is selected).
> My motivations were:
>
> enable IP address static assignment based on MAC address (for this purpose
> the MAC address must be fixed, and not changed for each new connection);
> avoid network traffic being filtered by firewalls that apply MAC filtering
> rules.

Hi Marcelo,

thanks for your patch.

> I have successfully tested this code in Ubuntu (kernel 2.6.35-28-generic)
> and CentOS (kernel 2.6.18-238.el5xen) operating systems.

Do you have more info on the version of vpnc where your patch applies?
0.5.3 is latest release, but quite old.
Could you check if it applies to trunk code in svn?

Also, please provide the patch as
"diff -urp vpnc-0.5.3/ vpnc-0.5.3-macaddr-support/"

In your code, if user specifies a MAC address, he/she expect this is
set on the interface.
But the platform could provide no support for SIOCSIFHWADDR.
I would expect an error message or at least a warning in this case.

I'm not sure, but I would also expect an error if user specifies both
MAC and TAP.
This should be detected directly in config.c

> It would be nice if you could integrate this patch in the next release.

Agree!

Best Regards
Antonio
_______________________________________________
vpnc-devel mailing list
vpnc-devel@unix-ag.uni-kl.de
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/