Mailing List Archive

Divorcing varnishtest from varnish-cache
We discussed this at our developer summit in Hamburg yesterday
and I had made some experiments on the train down there.

The suggested plan right now is:

1. Try to gain control of the empty 'vtest' account on github
I've sent them a message. (Do we know any insiders ?)
Alternative name suggestions if this fails are most welcome.

2. Create a vtest repository which contains:

./README
./Makefile
./lib/
(slimmed down) files from lib/libvarnish
./src/
bin/varnishtest/*.[ch]
./tests/
a?????.vtc tests, purged from varnishd usage

My in-train test got it down to 29kLOC.

3. Give developer access to interested & trustworthy parties

We should probably define an informal review/design process, so
that nobody drags the carpet under somebody else by accident.

4. No binary packages/releases will be built at this time

HAproxy and Varnish-Cache can/will import by whatever
means from the new common 'vtest' project, and build
vtest the way which works best for their project.
(V-C obviously have some backwards compat issues)

5. See where that takes us.

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
Hi Poul-Henning!

On Sat, Sep 22, 2018 at 05:34:17PM +0000, Poul-Henning Kamp wrote:
> We discussed this at our developer summit in Hamburg yesterday
> and I had made some experiments on the train down there.
>
> The suggested plan right now is:
>
> 1. Try to gain control of the empty 'vtest' account on github
> I've sent them a message. (Do we know any insiders ?)
> Alternative name suggestions if this fails are most welcome.

Unfortunately they don't have much balls overthere. We've had quite
some difficulties recovering the haproxy account. All they could do
was to point us to other projects the same contributor contributed
to hoping that we could contact him opening issues overthere :-/

In the end we were lucky because the guy is very friendly to haproxy
and was just never reading his emails, so once he found them he moved
around and let us install our stuff there. So I woudln't count on any
help from github. I think they are very strict regarding any form of
information leak, which can be understandable given the numerous
projects they host.

I'd suggest to try to contact the vtest account owner directly. If
that fails, maybe leaving it under the varnish account would still
make sense since that's where it comes from and it's not a secret.

> 2. Create a vtest repository which contains:
>
> ./README
> ./Makefile
> ./lib/
> (slimmed down) files from lib/libvarnish
> ./src/
> bin/varnishtest/*.[ch]
> ./tests/
> a?????.vtc tests, purged from varnishd usage
>
> My in-train test got it down to 29kLOC.

Quite good!

> 3. Give developer access to interested & trustworthy parties
>
> We should probably define an informal review/design process, so
> that nobody drags the carpet under somebody else by accident.

Probably.

> 4. No binary packages/releases will be built at this time
>
> HAproxy and Varnish-Cache can/will import by whatever
> means from the new common 'vtest' project, and build
> vtest the way which works best for their project.
> (V-C obviously have some backwards compat issues)

I think that emitting a 1.0 version "soon" could boost adoption and
send a signal that it's good enough for what all of us currently need.
It seems to me that the utility is already usable on both projects so
it might be a good way to tell the community "look, now it's born,
it's reliable, if it finds bugs they're more likely in the project
that uses it than in the utility itself". With a bit of luck, other
projects could be attracted.

Thanks for the update!
Willy
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
On 9/22/18 20:17, Willy Tarreau wrote:
>>
>> 1. Try to gain control of the empty 'vtest' account on github
>> I've sent them a message. (Do we know any insiders ?)
>> Alternative name suggestions if this fails are most welcome.
>
> Unfortunately they don't have much balls overthere.

If this becomes too much trouble, some searches just showed me that
"p-test", "pxytest" and "prox-test" (meant to suggest "proxy test") are
not in use at github. "proxytest" and "proxy_test" are taken by both
repos and users, not too surprisingly, as are "proxtest", "ptest" and
"proxitest".

phk wanted something with "v" to motivate the ".vtc" extension. The
explanation for that might have to be just: "it's legacy, don't ask".


Best,
Geoff
--
** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

Tel +49 40 2880 5731
Mob +49 176 636 90917
Fax +49 40 42949753

http://uplex.de
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
--------
In message <71064.1537637657@critter.freebsd.dk>, "Poul-Henning Kamp" writes:

>1. Try to gain control of the empty 'vtest' account on github
> I've sent them a message. (Do we know any insiders ?)
> Alternative name suggestions if this fails are most welcome.

OK, color me amazed... I now have the @vtest account on github.

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
--------

I guess my age is showing, as I almost forgot the most important thing:

0. We need a cute 'vtest' logo

:-)

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
On Mon, Sep 24, 2018 at 10:39:38AM +0000, Poul-Henning Kamp wrote:
> --------
> In message <71064.1537637657@critter.freebsd.dk>, "Poul-Henning Kamp" writes:
>
> >1. Try to gain control of the empty 'vtest' account on github
> > I've sent them a message. (Do we know any insiders ?)
> > Alternative name suggestions if this fails are most welcome.
>
> OK, color me amazed... I now have the @vtest account on github.

Oh, excellent!

Willy
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
On Sat, 22 Sep 2018 17:34:17 +0000
"Poul-Henning Kamp" <phk@phk.freebsd.dk> wrote:
> 4. No binary packages/releases will be built at this time
>
> HAproxy and Varnish-Cache can/will import by whatever
> means from the new common 'vtest' project, and build
> vtest the way which works best for their project.
> (V-C obviously have some backwards compat issues)

From a distribution standpoint ... why not make it into a library from
the beginning to avoid code duplication?

--
openSUSE - SUSE Linux is my linux
openSUSE is good for you
www.opensuse.org
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
Hi Marcus,

On Mon, Sep 24, 2018 at 02:04:33PM +0200, Marcus R?ckert wrote:
> On Sat, 22 Sep 2018 17:34:17 +0000
> "Poul-Henning Kamp" <phk@phk.freebsd.dk> wrote:
> > 4. No binary packages/releases will be built at this time
> >
> > HAproxy and Varnish-Cache can/will import by whatever
> > means from the new common 'vtest' project, and build
> > vtest the way which works best for their project.
> > (V-C obviously have some backwards compat issues)
>
> >From a distribution standpoint ... why not make it into a library from
> the beginning to avoid code duplication?

It would in my opinion cause more code duplication in fact. It really
is a complete utility already and splitting it would force both projects
to reimplement part of the glue needed to use the common parts. That
would create undesired dependencies and conflicts for no benefit.

I'm pretty sure that soon what will be needed is just
"git clone github:/vtest/vtest", configure, make and then you're done.
That's very convenient for a developer.

Cheers,
Willy
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
--------
In message <20180924140433.68447f5c@barghest.suse.de>, Marcus =?UTF-8?B?UsO8Y2tlcnQ=?= writes:
>On Sat, 22 Sep 2018 17:34:17 +0000
>"Poul-Henning Kamp" <phk@phk.freebsd.dk> wrote:
>> 4. No binary packages/releases will be built at this time
>>
>> HAproxy and Varnish-Cache can/will import by whatever
>> means from the new common 'vtest' project, and build
>> vtest the way which works best for their project.
>> (V-C obviously have some backwards compat issues)
>
>From a distribution standpoint ... why not make it into a library from
>the beginning to avoid code duplication?

Because I want to see where this takes us as we gain some hands-on
experience with sharing code, rather than try to plot out a course
which may not be relevant to our needs.

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
--------

I have made a first export/import of VTest now:

https://github.com/vtest/VTest

The Makefile is very rudimentary and mostly so that I could see that
the convert.sh script does something sensible.

Let the experiments start...

Poul-Henning

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
Re: Divorcing varnishtest from varnish-cache [ In reply to ]
On Tue, Sep 25, 2018 at 08:57:00PM +0000, Poul-Henning Kamp wrote:
> --------
>
> I have made a first export/import of VTest now:
>
> https://github.com/vtest/VTest
>
> The Makefile is very rudimentary and mostly so that I could see that
> the convert.sh script does something sensible.
>
> Let the experiments start...

A very (too) quick check gives me this :

python3 src/huffman_gen.py src/tbl/vhp_huffman.h > src/vtc_h2_dectbl.h
/bin/sh: python3: command not found

I modified the makefile to directly execute "src/huffman_gen.py" which
apparently uses "usr/bin/env python" to find it and it went OK for this
part (copy-pasted below for illustration, tabs/spaces mangled) :

diff --git a/Makefile b/Makefile
index a51ea1f..e3a008e 100644
--- a/Makefile
+++ b/Makefile
@@ -11,7 +11,7 @@ vtest: \
src/sequences src/gensequences \
src/huffman_gen.py src/tbl/vhp_huffman.h
awk -f src/gensequences src/sequences > src/teken_state.h
- python3 src/huffman_gen.py src/tbl/vhp_huffman.h > src/vtc_h2_dectbl.h
+ src/huffman_gen.py src/tbl/vhp_huffman.h > src/vtc_h2_dectbl.h
${CC} \
-o vtest \
-I src \

But it failed slightly later :

src/vtc_varnish.c:46:22: fatal error: vapi/vsc.h: No such file or directory

I indeed don't have this file at all in the repo. However that's
all for me for this evening.

Thanks!
Willy
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev