Mailing List Archive

Author: des
Date: 2007-12-18 17:47:44 +0100 (Tue, 18 Dec 2007)
New Revision: 2297

Modified:
trunk/varnish-tools/regress/lib/Varnish/Test/Case.pm
trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
trunk/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm
trunk/varnish-tools/regress/lib/Varnish/Test/Report/report.html
Log:
Add $NOTES as a hack to document the fact that we know 1.1.2 fails some of
the tests. This should be revisited later; ideally, the framework should
know which tests are expected to pass and which are expected to fail, and
flag any deviation (if a test is expected to fail but passes, it is
probable that the test is broken)


Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-12-18 16:13:36 UTC (rev 2296)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-12-18 16:47:44 UTC (rev 2297)
@@ -35,6 +35,7 @@

our $DESCR = "Tests Varnish's ability to correctly pass POST requests" .
" to the backend, and their replies back to the client.";
+our $NOTES = "1.1.2 is expected to fail one of three subtests.";

our $VCL = <<EOVCL;
sub vcl_recv {

Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm 2007-12-18 16:13:36 UTC (rev 2296)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm 2007-12-18 16:47:44 UTC (rev 2297)
@@ -34,6 +34,7 @@
use base 'Varnish::Test::Case';

our $DESCR = "Tests Varnish's ability to handle pipelined requests.";
+our $NOTES = "1.1.2 is expected to fail one of two subtests.";

our %CONTENT = (
'Gibson' => "The sky above the port was the color of television, tuned to a dead channel.",

Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case.pm
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Case.pm 2007-12-18 16:13:36 UTC (rev 2296)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case.pm 2007-12-18 16:47:44 UTC (rev 2297)
@@ -232,9 +232,11 @@
no strict 'refs';
my $name = ${ref($self)."::NAME"} || (split('::', ref($self)))[-1];
my $descr = ${ref($self)."::DESCR"} || "N/A";
+ my $notes = ${ref($self)."::NOTES"} || "N/A";
return {
'name' => $name,
'descr' => $descr,
+ 'notes' => $notes,
'count' => $self->{'count'},
'pass' => $self->{'successful'},
'fail' => $self->{'failed'},

Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Report/report.html
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Report/report.html 2007-12-18 16:13:36 UTC (rev 2296)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Report/report.html 2007-12-18 16:47:44 UTC (rev 2297)
@@ -16,7 +16,8 @@
.pass { width: 5%; }
.fail { width: 5%; }
.time { width: 5%; text-align: right; }
-.descr { width: 70%; }
+.descr { width: 50%; }
+.notes { width: 20%; }
</style>
</head>
<!-- USE ms = format('%5.3f') -->
@@ -31,6 +32,7 @@
<th class="fail">Fail</th>
<th class="time">Time</th>
<th class="descr">Description</th>
+ <th class="notes">Notes</th>
</tr>
</thead>
<!-- FOREACH case = cases -->
@@ -45,6 +47,7 @@
<td class="fail"><!-- case.fail --></td>
<td class="time"><!-- ms(case.time) --> s</td>
<td class="descr"><!-- case.descr --></td>
+ <td class="notes"><!-- case.notes --></td>
</tr>
<!-- END -->
<tfoot>
@@ -55,6 +58,7 @@
<td class="fail"><!-- fail --></td>
<td class="time"><!-- ms(time) --> s</td>
<td class="descr">&nbsp;</td>
+ <td class="notes">&nbsp;</td>
</tr>
</tfoot>
</table>