Mailing List Archive: r1815 - trunk/varnish-tools/regress/lib/Varnish/Test/Case

r1815 - trunk/varnish-tools/regress/lib/Varnish/Test/Case

Aug 8, 2007, 5:10 AM

Post #1 of 3 (79 views)

Author: des
Date: 2007-08-08 14:10:17 +0200 (Wed, 08 Aug 2007)
New Revision: 1815

Modified:
trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
Log:
I'm not sure Varnish should GET from the backend when the client used POST
but the VCL script decided to cache the request anyway. Treat it as an
error for now.

Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-08-08 12:08:25 UTC (rev 1814)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-08-08 12:10:17 UTC (rev 1815)
@@ -95,9 +95,15 @@
return 'OK';
}

-sub server_post($$$$) {
+sub server_get($$$) {
my ($self, $request, $response) = @_;

+ die "Got GET request instead of POST\n";
+}
+
+sub server_post($$$) {
+ my ($self, $request, $response) = @_;
+
if ($request->content()) {
$response->content("The Magic Words are " . $request->content());
} else {

r1815 - trunk/varnish-tools/regress/lib/Varnish/Test/Case [ In reply to ]

phk at phk

Aug 8, 2007, 6:34 AM

Post #2 of 3 (79 views)

Permalink

In message <20070808121017.7C6801EC2A3 at projects.linpro.no>, des at projects.linpro
.no writes:
>Author: des
>Date: 2007-08-08 14:10:17 +0200 (Wed, 08 Aug 2007)
>New Revision: 1815
>
>Modified:
> trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
>Log:
>I'm not sure Varnish should GET from the backend when the client used POST
>but the VCL script decided to cache the request anyway. Treat it as an
>error for now.

POST should always be handled as pipe, unless we positively tell
otherwise in VCL.

>
>
>Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
>===================================================================
>--- trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-08-08 12:08:25 UTC (rev 1814)
>+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-08-08 12:10:17 UTC (rev 1815)
>@@ -95,9 +95,15 @@
> return 'OK';
> }
>
>-sub server_post($$$$) {
>+sub server_get($$$) {
> my ($self, $request, $response) = @_;
>
>+ die "Got GET request instead of POST\n";
>+}
>+
>+sub server_post($$$) {
>+ my ($self, $request, $response) = @_;
>+
> if ($request->content()) {
> $response->content("The Magic Words are " . $request->content());
> } else {
>
_______________________________________________
>varnish-commit mailing list
>varnish-commit at projects.linpro.no
>http://projects.linpro.no/mailman/listinfo/varnish-commit
>

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

r1815 - trunk/varnish-tools/regress/lib/Varnish/Test/Case [ In reply to ]

des at linpro

Aug 8, 2007, 7:05 AM

Post #3 of 3 (79 views)

Permalink

"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
> POST should always be handled as pipe, unless we positively tell
> otherwise in VCL.

Yes. In this case we do (in one of three tests). There are good
reasons for doing so under certain conditions.

DES
--
Dag-Erling Sm?rgrav
Senior Software Developer
Linpro AS - www.linpro.no