Mailing List Archive: #1816: Return 304 for If-None-Match on weak ETag match (cache hit)

#1816: Return 304 for If-None-Match on weak ETag match (cache hit)

Nov 12, 2015, 8:48 AM

Post #1 of 4 (1168 views)

#1816: Return 304 for If-None-Match on weak ETag match (cache hit)
---------------------------------------------+----------------------
Reporter: teohhanhui | Type: defect
Status: new | Priority: normal
Milestone: | Component: varnishd
Version: 4.0.3 | Severity: normal
Keywords: 304 if-none-match weak etag hit |
---------------------------------------------+----------------------
Currently when the client sends a request with weak ETag and it matches,
Varnish returns response with 200 status code on cache hit.

But it should actually return 304 just like with strong ETag.

See https://tools.ietf.org/html/rfc7232#section-3.2

> 3.2. If-None-Match
> A recipient MUST use the weak comparison function when comparing entity-
tags for If-None-Match (Section 2.3.2), since weak entity-tags can be used
for cache validation even if there have been changes to the representation
data.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1816>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1816: Return 304 for If-None-Match on weak ETag match (cache hit) [ In reply to ]

varnish-bugs at varnish-cache

Dec 4, 2015, 2:35 AM

Post #2 of 4 (1128 views)

Permalink

#1816: Return 304 for If-None-Match on weak ETag match (cache hit)
---------------------------------------------+-----------------------
Reporter: teohhanhui | Owner: fgsch
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: 304 if-none-match weak etag hit |
---------------------------------------------+-----------------------
Changes (by fgsch):

* owner: => fgsch
* status: new => assigned

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1816#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1816: Return 304 for If-None-Match on weak ETag match (cache hit) [ In reply to ]

varnish-bugs at varnish-cache

Dec 11, 2015, 7:32 AM

Post #3 of 4 (1127 views)

Permalink

#1816: Return 304 for If-None-Match on weak ETag match (cache hit)
---------------------------------------------+---------------------
Reporter: teohhanhui | Owner: fgsch
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution: fixed
Keywords: 304 if-none-match weak etag hit |
---------------------------------------------+---------------------
Changes (by Federico G. Schwindt <fgsch@â€¦>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [6469345568aa852258e71df7e42492dfe8cac46b]:
{{{
#!CommitTicketReference repository=""
revision="6469345568aa852258e71df7e42492dfe8cac46b"
Use a weak comparison function for If-None-Match

As per RFC 7232.

Fixes #1816.
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1816#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Re: #1816: Return 304 for If-None-Match on weak ETag match (cache hit) [ In reply to ]

varnish-bugs at varnish-cache

Jan 14, 2016, 6:15 AM

Post #4 of 4 (1088 views)

Permalink

#1816: Return 304 for If-None-Match on weak ETag match (cache hit)
---------------------------------------------+---------------------
Reporter: teohhanhui | Owner: fgsch
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution: fixed
Keywords: 304 if-none-match weak etag hit |
---------------------------------------------+---------------------

Comment (by Lasse Karstensen <lkarsten@â€¦>):

In [778283389bae7809dd8fc40565ae64ba85fbfa4e]:
{{{
#!CommitTicketReference repository=""
revision="778283389bae7809dd8fc40565ae64ba85fbfa4e"
Use a weak comparison function for If-None-Match

As per RFC 7232.

Fixes #1816.
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1816#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs