Mailing List Archive

#1813: Duplicate -a leads to assert instead of error message.
----------------------+--------------------
Reporter: lkarsten | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 4.1.0
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------
Description changed by lkarsten:

Old description:

> On 4.1.0, if you add the same -a twice, you get this error:
>
> {{{
> varnish> root@lima:/etc/varnish# varnishadm panic.show
> Last panic at: Mon, 02 Nov 2015 10:20:15 GMT
> Assert error in vca_acct(), cache/cache_acceptor.c line 490:
> Condition((listen(ls->sock, cache_param->listen_depth)) == 0) not true.
> errno = 98 (Address already in use)
> thread = (cache-acceptor)
> version = varnish-4.1.0 revision 3041728
> ident =
> Linux,3.16.0-4-amd64,x86_64,-junix,-smalloc,-smalloc,-hcritbit,epoll
> Backtrace:
> 0x433505: varnishd() [0x433505]
> 0x410f65: varnishd() [0x410f65]
> 0x7f78a92230a4: libpthread.so.0(+0x80a4) [0x7f78a92230a4]
> 0x7f78a8f5804d: libc.so.6(clone+0x6d) [0x7f78a8f5804d]
> }}}
>
> Child is continously being restarted.

New description:

On 4.1.0, if you add the same -a twice, you get this error:

{{{
varnish> root@lima:/etc/varnish# varnishadm panic.show
Last panic at: Mon, 02 Nov 2015 10:20:15 GMT
Assert error in vca_acct(), cache/cache_acceptor.c line 490:
Condition((listen(ls->sock, cache_param->listen_depth)) == 0) not true.
errno = 98 (Address already in use)
thread = (cache-acceptor)
version = varnish-4.1.0 revision 3041728
ident =
Linux,3.16.0-4-amd64,x86_64,-junix,-smalloc,-smalloc,-hcritbit,epoll
Backtrace:
0x433505: varnishd() [0x433505]
0x410f65: varnishd() [0x410f65]
0x7f78a92230a4: libpthread.so.0(+0x80a4) [0x7f78a92230a4]
0x7f78a8f5804d: libc.so.6(clone+0x6d) [0x7f78a8f5804d]
}}}

Child is continuously being restarted.

--

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1813#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1813: Duplicate -a leads to assert instead of error message.
----------------------+--------------------
Reporter: lkarsten | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 4.1.0
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by lkarsten):

{{{
[11:26:07] < phk> scn, re #1813 what kind of -a argument do you use that
the arg-check doesn't catch it ?
[11:26:16] < phk> critter phk> ./varnishd -a :8080 -a :8080 -d
[11:26:16] < phk> Error: Cannot open socket: :8080: Address already in use
[11:27:27] < scn> varnish 15719 1 1 11:22 ? 00:00:00
/usr/sbin/varnishd -a :80 -P /var/run/varnish.pid -f
/etc/varnish/default.vcl -a :80
[11:28:05] < scn> at some point i added -a :80 before -P in the systemd
service file
[11:28:39] < scn> due to dropping of privs before/after writing the
pidfile. i don't remember the details.
[11:28:45] < phk> scn, this must be some linuxy thing that allows you to
bind twice...
[11:29:27] < scn> this line was from ps way up in my scrollback buffer, it
would be longer. there is a PROXY listener as well.
}}}

todo: reproduce on linux.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1813#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1813: Duplicate -a leads to assert instead of error message.
----------------------+----------------------------------------
Reporter: lkarsten | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 4.1.0
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* status: new => closed
* owner: => Poul-Henning Kamp <phk@…>
* resolution: => fixed


Comment:

In [f861ad2174ffc85700c591fda0aadffe843d2ecf]:
{{{
#!CommitTicketReference repository=""
revision="f861ad2174ffc85700c591fda0aadffe843d2ecf"
Fail if multiple -a arguments return the same suckaddr.

Fixes #1813
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1813#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

#1813: Duplicate -a leads to assert instead of error message.
----------------------+----------------------------------------
Reporter: lkarsten | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 4.1.0
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------

Comment (by Lasse Karstensen <lkarsten@…>):

In [fc9b45f167b2b5c1b206e8bdaf4a00e06617c654]:
{{{
#!CommitTicketReference repository=""
revision="fc9b45f167b2b5c1b206e8bdaf4a00e06617c654"
Fail if multiple -a arguments return the same suckaddr.

Fixes #1813
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1813#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs