Mailing List Archive

#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat systemd service
#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat
systemd service
---------------------------------+-----------------------
Reporter: anders | Type: defect
Status: new | Priority: normal
Milestone: Varnish 4.0 release | Component: packaging
Version: 4.0.3 | Severity: normal
Keywords: redhat |
---------------------------------+-----------------------
I have vcc_err_unref set to off in varnish.params:

[root@no000010sapit0 ~]# grep ^DAE /etc/varnish/varnish.params
DAEMON_OPTS="-p vcc_err_unref=off"

But when I try to start Varnish it fails with unused subs:

[root@no000010sapit0 ~]# service varnish start
Redirecting to /bin/systemctl start varnish.service
Job for varnish.service failed. See 'systemctl status varnish.service' and
'journalctl -xn' for details.
[root@no000010sapit0 ~]# journalctl -xn | cat
-- Logs begin at Sun 2015-09-06 15:40:04 CEST, end at Wed 2015-09-09
09:35:22 CEST. --
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Message from
VCC-compiler:
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Unused sub
pass_if_gethead, defined:
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: ('input' Line
48 Pos 5)
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: sub
pass_if_gethead

The problem is that /usr/lib/systemd/system/varnish.service has an
ExecStartPre
that does not use/consider $DAEMON_OPTS. It needs to, particularly for
that vcc_err_unref=off setting.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1787>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat systemd service [ In reply to ]
#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat
systemd service
-----------------------+----------------------------------
Reporter: anders | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Varnish 4.0 release
Component: packaging | Version: 4.0.3
Severity: normal | Resolution:
Keywords: redhat |
-----------------------+----------------------------------
Description changed by fgsch:

Old description:

> I have vcc_err_unref set to off in varnish.params:
>
> [root@no000010sapit0 ~]# grep ^DAE /etc/varnish/varnish.params
> DAEMON_OPTS="-p vcc_err_unref=off"
>
> But when I try to start Varnish it fails with unused subs:
>
> [root@no000010sapit0 ~]# service varnish start
> Redirecting to /bin/systemctl start varnish.service
> Job for varnish.service failed. See 'systemctl status varnish.service'
> and 'journalctl -xn' for details.
> [root@no000010sapit0 ~]# journalctl -xn | cat
> -- Logs begin at Sun 2015-09-06 15:40:04 CEST, end at Wed 2015-09-09
> 09:35:22 CEST. --
> Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Message from
> VCC-compiler:
> Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Unused sub
> pass_if_gethead, defined:
> Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: ('input'
> Line 48 Pos 5)
> Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: sub
> pass_if_gethead
>
> The problem is that /usr/lib/systemd/system/varnish.service has an
> ExecStartPre
> that does not use/consider $DAEMON_OPTS. It needs to, particularly for
> that vcc_err_unref=off setting.

New description:

I have vcc_err_unref set to off in varnish.params:

{{{
[root@no000010sapit0 ~]# grep ^DAE /etc/varnish/varnish.params
DAEMON_OPTS="-p vcc_err_unref=off"
}}}

But when I try to start Varnish it fails with unused subs:

{{{
[root@no000010sapit0 ~]# service varnish start
Redirecting to /bin/systemctl start varnish.service
Job for varnish.service failed. See 'systemctl status varnish.service' and
'journalctl -xn' for details.
[root@no000010sapit0 ~]# journalctl -xn | cat
-- Logs begin at Sun 2015-09-06 15:40:04 CEST, end at Wed 2015-09-09
09:35:22 CEST. --
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Message from
VCC-compiler:
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: Unused sub
pass_if_gethead, defined:
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: ('input' Line
48 Pos 5)
Sep 09 09:35:22 no000010sapit0.moller.local varnishd[19404]: sub
pass_if_gethead
}}}

The problem is that /usr/lib/systemd/system/varnish.service has an
ExecStartPre
that does not use/consider $DAEMON_OPTS. It needs to, particularly for
that vcc_err_unref=off setting.

--

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1787#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat systemd service [ In reply to ]
#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat
systemd service
-----------------------+----------------------------------
Reporter: anders | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Varnish 4.0 release
Component: packaging | Version: 4.0.3
Severity: normal | Resolution:
Keywords: redhat |
-----------------------+----------------------------------

Comment (by fgsch):

Fixed in master in commit 28198ab847c60382576c91a916ee4657484dd44f.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1787#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat systemd service [ In reply to ]
#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat
systemd service
-----------------------+----------------------------------
Reporter: anders | Owner: lkarsten
Type: defect | Status: new
Priority: normal | Milestone: Varnish 4.0 release
Component: packaging | Version: 4.0.3
Severity: normal | Resolution:
Keywords: redhat |
-----------------------+----------------------------------
Changes (by lkarsten):

* owner: => lkarsten


Comment:

Summing this up: we need DAEMON_OPTS in the pre-command. Not in place in
4.1, haven't checked 4.0. Assuming ownership.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1787#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat systemd service [ In reply to ]
#1787: Varnish fails to start because of unused subs in VCL and bug in Red Hat
systemd service
-----------------------+----------------------------------
Reporter: anders | Owner: lkarsten
Type: defect | Status: closed
Priority: normal | Milestone: Varnish 4.0 release
Component: packaging | Version: 4.0.3
Severity: normal | Resolution: fixed
Keywords: redhat |
-----------------------+----------------------------------
Changes (by Lasse Karstensen <lkarsten@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [f8cdd8fcab29bc53cfc72964482ecafaaa85f94f]:
{{{
#!CommitTicketReference repository=""
revision="f8cdd8fcab29bc53cfc72964482ecafaaa85f94f"
Add DAEMON_OPTS to ExecStartPre.

Fixes: #1787
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1787#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs