Mailing List Archive

#1767: configtest is broken in 4.1
#1767: configtest is broken in 4.1
----------------------+-----------------------
Reporter: lkarsten | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: build | Version: 4.1.0-TP1
Severity: normal | Keywords:
----------------------+-----------------------
In master/4.1, we seem to bind to the listening ports even when we're just
parsing the configuration. This behaviour has changed since 4.0.

This affects how the "configtest" functionality of the init script works.

{{{
root@sierra:~# /opt/varnish/sbin/varnishd -a :80 -C \
-f /etc/varnish/default.vcl -n /tmp
Error: Could not bind to address :80: Address already in use
root@sierra:~# varnishd -V
varnishd (varnish-trunk revision 6179e31)
}}}

Expected: -C does not depend on a local listening port, and should do its
thing without trying to bind to any ports.

Workaround: removing any -a entries in the command line seem to fix it.

{{{
root@sierra:~# /opt/varnish/sbin/varnishd -f /etc/varnish/default.vcl -n
/tmp -C
(this works, C-code is output)

root@sierra:~# /opt/varnish/sbin/varnishd -f /etc/varnish/default.vcl -n
/tmp
Error: Could not bind to address *:80: Address already in use
(as expected)
}}}

Teaching the different init scripts how to parse and filter the contents
of $DAEMON_ARGS feels like the wrong solution.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1767>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1767: configtest is broken in 4.1 [ In reply to ]
#1767: configtest is broken in 4.1
----------------------+----------------------------------------
Reporter: lkarsten | Owner: Poul-Henning Kamp <phk@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: build | Version: 4.1.0-TP1
Severity: normal | Resolution: fixed
Keywords: |
----------------------+----------------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* owner: => Poul-Henning Kamp <phk@…>
* status: new => closed
* resolution: => fixed


Comment:

In [1ff5897b6d18954fc209b68270c637a510f30e79]:
{{{
#!CommitTicketReference repository=""
revision="1ff5897b6d18954fc209b68270c637a510f30e79"
Make -a argument checking a two step process:

We always do the DNS resolution when we hit -a arguments, but the
test that we can bind to the address is postponed until after the -C
argument processing.

Fixes: #1767
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1767#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs