Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Varnish>
  3. Bugs
#1735: Changes to varnishapi.pc.in break module compilation.
varnish-bugs at varnish-cache
May 12, 2015, 10:54 AM
Post #1 of 10 (1940 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
---------------------+----------------------
Reporter: drogers | Type: defect
Status: new | Priority: normal
Milestone: | Component: varnishd
Version: 4.0.3 | Severity: normal
Keywords: |
---------------------+----------------------
The removal of 'vmodincludedir' from varnishapi.pc.in in
61cdf24bb88a18d175c8b6e1c4dc26593728fa27 breaks the compilation of (at
least) libmod-vsthrottle (https://github.com/varnish/libvmod-vsthrottle)
and boltsort (https://github.com/vimeo/libvmod-boltsort).

{{{
make all-recursive
make[1]: Entering directory `/tmp/libvmod-boltsort-master'
Making all in src
make[2]: Entering directory `/tmp/libvmod-boltsort-master/src'
/bin/sh ../libtool --tag=CC --mode=compile gcc -std=gnu99
-DHAVE_CONFIG_H -I. -I.. -I -I/usr/include/varnish -g -O2 -MT vcc_if.lo
-MD -MP -MF .deps/vcc_if.Tpo -c -o vcc_if.lo vcc_if.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I
-I/usr/include/varnish -g -O2 -MT vcc_if.lo -MD -MP -MF .deps/vcc_if.Tpo
-c vcc_if.c -fPIC -DPIC -o .libs/vcc_if.o
vcc_if.c:8:17: fatal error: vrt.h: No such file or directory
#include "vrt.h"
^
compilation terminated.
make[2]: *** [vcc_if.lo] Error 1
make[2]: Leaving directory `/tmp/libvmod-boltsort-master/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/libvmod-boltsort-master'
make: *** [all] Error 2

}}}

Note the empty -I option, which confuses gcc.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 12, 2015, 11:57 AM
Post #2 of 10 (1922 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------
Changes (by fgsch):

* status: new => needinfo


Comment:

Both work for me on a fresh checkout with the correct packages installed:

{{{
ii libvarnishapi-dev 4.0.3-2~trusty amd64
development files for Varnish
ii libvarnishapi1 4.0.3-2~trusty amd64
shared libraries for Varnish
ii varnish 4.0.3-2~trusty amd64
state of the art, high-performance web accelerator
}}}

If it keeps occurring with a clean repo please share the configure output
and installed packages.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 12, 2015, 12:48 PM
Post #3 of 10 (1928 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by drogers):

Here are my installed RPMs, from the varnish yum repo:

{{{
varnish-release-4.0-3.el6.noarch
varnish-libs-4.0.3-1.el6.x86_64
varnish-libs-devel-4.0.3-1.el6.x86_64
varnish-4.0.3-1.el6.x86_64
}}}

Module sources are from https://github.com/varnish/libvmod-
vsthrottle/archive/master.zip and https://github.com/vimeo/libvmod-
boltsort/archive/master.zip

configure output (note, configure gets confused by the lack of the
'vmodincludedir' variable as well:

{{{
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking for gcc option to accept ISO C99... -std=gnu99
checking for gcc -std=gnu99 option to accept ISO Standard C... (cached)
-std=gnu99
checking how to run the C preprocessor... gcc -E
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for fgrep... /bin/grep -F
checking for ld used by gcc -std=gnu99... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64
-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain
format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc -std=gnu99
object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc -std=gnu99 supports -fno-rtti -fno-exceptions... no
checking for gcc -std=gnu99 option to produce PIC... -fPIC -DPIC
checking if gcc -std=gnu99 PIC flag -fPIC -DPIC works... yes
checking if gcc -std=gnu99 static flag -static works... no
checking if gcc -std=gnu99 supports -c -o file.o... yes
checking if gcc -std=gnu99 supports -c -o file.o... (cached) yes
checking whether the gcc -std=gnu99 linker (/usr/bin/ld -m elf_x86_64)
supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking whether make sets $(MAKE)... (cached) yes
checking for rst2man... rst2man
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for ANSI C header files... (cached) yes
checking sys/stdlib.h usability... no
checking sys/stdlib.h presence... no
checking for sys/stdlib.h... no
checking for python3... no
checking for python3.1... no
checking for python3.2... no
checking for python2.7... python2.7
checking vsha256.h usability... no
checking vsha256.h presence... no
checking for vsha256.h... no
checking cache/cache.h usability... no
checking cache/cache.h presence... no
checking for cache/cache.h... no
checking for varnishtest... /usr/bin/varnishtest
checking for varnishd... /usr/sbin/varnishd
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands
}}}

This is Amazon Linux, FYI.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 12, 2015, 1:44 PM
Post #4 of 10 (1926 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by fgsch):

Works for me in Centos 6 as well.

Can you attach the config.log file?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 12, 2015, 2:31 PM
Post #5 of 10 (1916 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by drogers):

Sure, here it is with those lines missing.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 12, 2015, 3:28 PM
Post #6 of 10 (1924 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by fgsch):

That's pretty weird. Your config.log defines VMOD_INCLUDE_DIR but that
doesn't exist anymore.
Do you have multiple varnishapi.pc? Did you re-run autogen.sh?

Can you also include your configure and varnishapi.pc?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:5>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 13, 2015, 9:20 AM
Post #7 of 10 (1909 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by drogers):

Sure, they're attached now.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 13, 2015, 9:26 AM
Post #8 of 10 (1918 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by fgsch):

Thanks.

Sorry, forgot to mention, can you also include varnish.m4?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:7>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 13, 2015, 12:06 PM
Post #9 of 10 (1916 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+-----------------------
Reporter: drogers | Owner:
Type: defect | Status: needinfo
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by drogers):

So, this is rather embarrassing, but it turns out that our puppet config
was overwriting the varnish.m4 file with an older version. Once I stopped
it from doing that, it worked fine.

Sorry for the confusion, and thanks for your help.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:8>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
Re: #1735: Changes to varnishapi.pc.in break module compilation. [ In reply to ]
varnish-bugs at varnish-cache
May 13, 2015, 2:44 PM
Post #10 of 10 (1907 views)
Permalink
#1735: Changes to varnishapi.pc.in break module compilation.
----------------------+----------------------
Reporter: drogers | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 4.0.3
Severity: normal | Resolution: invalid
Keywords: |
----------------------+----------------------
Changes (by fgsch):

* status: needinfo => closed
* resolution: => invalid


Comment:

No worries. Thanks for confirming.

I will close this now.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1735#comment:9>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal