Mailing List Archive

#3836: Author value in RSS feed is not compliant with RSS 2.0 specs.
----------------------+-----------------------------------------------------
Reporter: eblot | Owner: eblot
Type: defect | Status: new
Priority: lowest | Milestone:
Component: general | Version: 0.10
Severity: trivial | Resolution:
Keywords: needinfo |
----------------------+-----------------------------------------------------
Changes (by mgood):

* keywords: rfc => needinfo

Comment:

Replying to [ticket:3836 eblot]:
> Trac fills in the author value, whatever its kind: the author
'''name''', or the email address if it exists.
>
> Should we disable the author tag for users without an email address?

AFAICT it already only includes emails, not simply names:
{{{
if:event.author.email ?>
<author><?cs var:event.author.email ?></author><?cs
/if ?>
}}}

Am I missing something?

--
Ticket URL: <http://trac.edgewall.org/ticket/3836#comment:1>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---

#3836: Author value in RSS feed is not compliant with RSS 2.0 specs.
----------------------+-----------------------------------------------------
Reporter: eblot | Owner: eblot
Type: defect | Status: new
Priority: lowest | Milestone:
Component: general | Version: 0.10
Severity: trivial | Resolution:
Keywords: needinfo |
----------------------+-----------------------------------------------------
Comment (by eblot):

Replying to [comment:1 mgood]:
> Am I missing something?

For timeline_rss.cs, you're right. However, for the other RSS sources, you
can find:

{{{
$ grep -i '<author>' templates/*
templates/log_rss.cs: if:change.author ?><author><?cs
var:change.author ?></author><?cs
templates/query_rss.cs: <author><?cs var:result.reporter
?></author><?cs
templates/report_rss.cs: <?cs if:author ?><author><?cs var:author
?></author><?cs /if ?>
templates/ticket_rss.cs: if:change.author ?><author><?cs
var:change.author ?></author><?cs
templates/timeline_rss.cs: <author><?cs var:event.author.email
?></author><?cs
}}}

`change.author`, for example, produces an invalid feed.

--
Ticket URL: <http://trac.edgewall.org/ticket/3836#comment:2>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---

#3836: Author value in RSS feed is not compliant with RSS 2.0 specs.
----------------------+-----------------------------------------------------
Reporter: eblot | Owner: eblot
Type: defect | Status: new
Priority: lowest | Milestone:
Component: general | Version: 0.10
Severity: trivial | Resolution:
Keywords: needinfo |
----------------------+-----------------------------------------------------
Comment (by cboos):

Note also that in various places in the code, the value of `change.author`
will actually depend on the format used (i.e. it's often special cased for
RSS).
That's a bit error prone, for sure, but I wouldn't invest too much time on
that, as we can use the migration to Genshi as an opportunity to improve
this (like calling the author validation code directly from the .rss
templates).

--
Ticket URL: <http://trac.edgewall.org/ticket/3836#comment:3>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets@googlegroups.com
To unsubscribe from this group, send email to trac-tickets-unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---