Mailing List Archive

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From parkerm@pobox.com 2004-06-27 21:40 -------
Appears to be from r22211:

Modified: spamassassin/trunk/spamd/spamd.raw
==============================================================================
--- spamassassin/trunk/spamd/spamd.raw (original)
+++ spamassassin/trunk/spamd/spamd.raw Sun Jun 27 19:45:04 2004
@@ -1042,7 +1042,7 @@
\$actual_length; # is set or not.
while ( $_ = $client->getline() ) {
$actual_length += length($_);
- last if $actual_length > ${$final_length};
+ last if $actual_length >= ${$final_length};

push(@msglines, $_);
}


I backed it out an all was well again.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From sidney@sidney.com 2004-06-27 22:20 -------
Whoops, that was sloppy of me. Sorry. But can someone explains what
spamd_protocol_10 is testing there and why this fix breaks it?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550

sidney@sidney.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED



------- Additional Comments From sidney@sidney.com 2004-06-27 22:45 -------
I backed out the fix to bug 3527, committed to svn rev 22228 and I'm reopening
bug 3527

I'm doing this without review because it is undoing the obviously flawed votes
and commit that we just did. Closing this bug as fixed, because now it is and it
will stay fixed if we don't do it again :-)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From jm@jmason.org 2004-06-27 23:06 -------
Subject: Re: spamd_protocol_10 test fails

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Whoops, that was sloppy of me. Sorry. But can someone explains what
> spamd_protocol_10 is testing there and why this fix breaks it?

it tests backwards compatibility with clients using SPAMD protocol version
1.0. (there are some out there.)

protocol v1.0 didn't have a Content-Length hdr, if I recall correctly.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFA37VUQTcbUG5Y7woRAgKqAJ9Krh5WxDUH6DzG5FWvACTsJortJACgkEmu
J4Sn4WnUbQGniBSQWWAn/a0=
=LpfV
-----END PGP SIGNATURE-----





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550

spamassassin-contrib@msquadrat.de changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |3527
nThis| |
Status|RESOLVED |REOPENED
Resolution|FIXED |



------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-06-28 01:51 -------
Ugh, please Sidney, don't be so fast. Now I don't know where to comment on
this... Marking this as a blocker for bug 3527 is better.

This fails because to shortcut a comparison, I introduced the $final_length
pointer. If $expected_length isn't defined, the $final_length is simply set to
the $current_length so there are always two same vars compared.

This of course worked for a >-comparison, but not a >=. So the way to fix both
these bugs is to do it the "classic" way. Patch follows.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-06-28 01:53 -------
Created an attachment (id=2076)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2076&action=view)
patch against spamd.raw

This patch gets rid od $final_length and reintroduces the fix for bug 3527.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From sidney@sidney.com 2004-06-28 02:07 -------
Oh, we collided ... I posted the same comment on the other bug, suggesting the
same fix. But you got the patch in first and it's time for me to read a bedtime
story to my kids. I'll review your patch after they are asleep.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.spamassassin.org/show_bug.cgi?id=3550





------- Additional Comments From sidney@sidney.com 2004-06-28 03:23 -------
+1 on the patch




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.