Mailing List Archive

[Bug 3334] journal_live_path returning an invalid path for bayes _journal
http://bugzilla.spamassassin.org/show_bug.cgi?id=3334

parkerm@pobox.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.1.0 |3.0.0





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 3334] journal_live_path returning an invalid path for bayes _journal [ In reply to ]
http://bugzilla.spamassassin.org/show_bug.cgi?id=3334

parkerm@pobox.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |spamassassin-
| |dev@incubator.apache.org
AssignedTo|spamassassin- |parkerm@pobox.com
|dev@incubator.apache.org |



------- Additional Comments From parkerm@pobox.com 2004-06-04 08:10 -------
Taking.

The easy fix here is to just remove the journal filename cache. However, this
is a nice optimization because it keeps us from having to continually run
sed_path on the journal filename.

So, I'll investigate doing something else here.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 3334] journal_live_path returning an invalid path for bayes _journal [ In reply to ]
http://bugzilla.spamassassin.org/show_bug.cgi?id=3334





------- Additional Comments From jm@jmason.org 2004-06-04 18:19 -------
Mike -- maintain a copy of what the $conf member was, at the last time the
sed_path() lookup was performed. if that changes, then the cached value is
invalidated.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 3334] journal_live_path returning an invalid path for bayes _journal [ In reply to ]
http://bugzilla.spamassassin.org/show_bug.cgi?id=3334





------- Additional Comments From parkerm@pobox.com 2004-06-04 18:43 -------
Subject: Re: journal_live_path returning an invalid path for bayes _journal

On Fri, Jun 04, 2004 at 06:19:35PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
>
> ------- Additional Comments From jm@jmason.org 2004-06-04 18:19 -------
> Mike -- maintain a copy of what the $conf member was, at the last time the
> sed_path() lookup was performed. if that changes, then the cached value is
> invalidated.
>

We do. The problem is, and I haven't traced it all the way through so
I might be a little off, that when spamd starts up it does the little
pre-compile step that sets up temp userstate dirs and what not and
processes a fake msg. Then it sets things back and is ready for
processing. The DBM module caches the journal path/filename with this
temp userstate and just returns that each time.

It's ok to cache because we generally create a new object each time we
change users. However this startup step doesn't create a new object
so we see the problem.

My current fix, is during the startup (compile_now) step it calls a
clear_cached_dirs method on the Bayes module that clears any cached
values (currently just this one) and we're all good.

Not employing a cache causes an ~8% slow down in processing.

Michael





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 3334] journal_live_path returning an invalid path for bayes _journal [ In reply to ]
http://bugzilla.spamassassin.org/show_bug.cgi?id=3334





------- Additional Comments From parkerm@pobox.com 2004-06-04 22:54 -------
Created an attachment (id=2002)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2002&action=view)
Patch File




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.