Mailing List Archive

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8203

Sidney Markowitz <sidney@sidney.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #1 from Sidney Markowitz <sidney@sidney.com> ---
Since DecodeShortURLs has to be able to follow https links,
LWP::Protocol::https is required for it to work in practice. Also, since bug
8104, sa-update also has to be able to access https links, which means that if
it has to fall back to using LWP::UserAgent it also will require
LWP::Protocol::https.

The correct fix, therefore, is to require LWP::Protocol::https everywhere that
LWP::UserAgent is required. In addition, the requirement has to be added to
t/decodeshorturl.t, i.e., skip the test if it is not installed.

% svn ci -m "Bug 8203 - Add LWP::Protocol::https as dependency where needed"
Makefile.PL lib/Mail/SpamAssassin/Plugin/DecodeShortURLs.pm
lib/Mail/SpamAssassin/Util/DependencyInfo.pm sa-update.raw t/decodeshorturl.t
Sending Makefile.PL
Sending lib/Mail/SpamAssassin/Plugin/DecodeShortURLs.pm
Sending lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Sending sa-update.raw
Sending t/decodeshorturl.t
Transmitting file data .....done
Committing transaction...
Committed revision 1914735.

--
You are receiving this mail because:
You are the assignee for the bug.