Mailing List Archive

Author: jm
Date: Tue May 10 00:28:43 2005
New Revision: 169430

URL: http://svn.apache.org/viewcvs?rev=169430&view=rev
Log:
better fix for the Net::Ident noise, works with perl 5.6.1 too

Modified:
spamassassin/trunk/lib/Mail/SpamAssassin.pm
spamassassin/trunk/lib/Mail/SpamAssassin/Util/DependencyInfo.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin.pm?rev=169430&r1=169429&r2=169430&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin.pm Tue May 10 00:28:43 2005
@@ -85,11 +85,6 @@
BEGIN {
eval { require Time::HiRes };
Time::HiRes->import( qw(time) ) unless $@;
-
- # and shut up the Net::Ident warnings: "Net::Ident::_export_hooks() called
- # too early to check prototype at /usr/share/perl5/Net/Ident.pm line 29."
- #commented out line: causes all kinds of warnings and errors
- #eval { sub Net::Ident::_export_hooks; };
}

use vars qw{

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Util/DependencyInfo.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin/Util/DependencyInfo.pm?rev=169430&r1=169429&r2=169430&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Util/DependencyInfo.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Util/DependencyInfo.pm Tue May 10 00:28:43 2005
@@ -152,6 +152,14 @@
sub debug_diagnostics {
my $out = "diag: perl platform: $] $^O\n";

+ # this avoids an unsightly warning due to a shortcoming of Net::Ident;
+ # "Net::Ident::_export_hooks() called too early to check prototype at
+ # /usr/share/perl5/Net/Ident.pm line 29." It only needs to be
+ # called here.
+ eval '
+ sub Net::Ident::_export_hooks;
+ ';
+
foreach my $moddef (sort (@MODULES, @OPTIONAL_MODULES)) {
my $module = $moddef->{module};
my $modver;