Mailing List Archive: RFC: removing rsyslog.service samples from git

RFC: removing rsyslog.service samples from git

Oct 20, 2023, 8:24 AM

Post #1 of 4 (153 views)

Hi all,

the git repository contains rsyslog.service sample files. Actually,
these have not been updated for years and do no longer match distro
policies.

Thankfully, Michael Biebl sent a PR to update the Debian parts. We had
a small discussion about the usefulness of these files at all. Michael
would be fine with removing them, and I think this is probably the
wisest thing to do. After all, these are not guinea rsyslog files.

Instead, we can replace them with hints where to look inside the
distro repositories. But I would not tend to do big research to find
all of them.

The PR is this one:

https://github.com/rsyslog/rsyslog/pull/5252

Question now: does anybody object to removing the rsyslog.service
files? If so, why is it important to keep them - and maybe how to
better maintain them.

TIA,
Rainer
_______________________________________________
rsyslog mailing list
https://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.

Re: RFC: removing rsyslog.service samples from git [ In reply to ]

rsyslog at lists

Oct 20, 2023, 8:38 AM

Post #2 of 4 (153 views)

Permalink

Hi Rainer:

Our source of truth for rsyslog.service has always been the copy packaged with the OS, and all modifications to it have come from vendor and systemd documentation. I do not personally see a need for that file to reside in the rsyslog repo.

Regards,

> On Oct 20, 2023, at 10:24, Rainer Gerhards via rsyslog <rsyslog@lists.adiscon.com> wrote:
>
> Hi all,
>
> the git repository contains rsyslog.service sample files. Actually,
> these have not been updated for years and do no longer match distro
> policies.
>
> Thankfully, Michael Biebl sent a PR to update the Debian parts. We had
> a small discussion about the usefulness of these files at all. Michael
> would be fine with removing them, and I think this is probably the
> wisest thing to do. After all, these are not guinea rsyslog files.
>
> Instead, we can replace them with hints where to look inside the
> distro repositories. But I would not tend to do big research to find
> all of them.
>
> The PR is this one:
>
> https://github.com/rsyslog/rsyslog/pull/5252
>
> Question now: does anybody object to removing the rsyslog.service
> files? If so, why is it important to keep them - and maybe how to
> better maintain them.
>
> TIA,
> Rainer
> _______________________________________________
> rsyslog mailing list
> https://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.

_______________________________________________
rsyslog mailing list
https://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.

Re: RFC: removing rsyslog.service samples from git [ In reply to ]

rsyslog at lists

Oct 20, 2023, 9:33 AM

Post #3 of 4 (153 views)

Permalink

Makes sense to me, they are far more dependent on the distro decisions than
anything we provide.

David Lang

On Fri, 20 Oct 2023, John Chivian via rsyslog wrote:

> Hi Rainer:
>
> Our source of truth for rsyslog.service has always been the copy packaged with the OS, and all modifications to it have come from vendor and systemd documentation. I do not personally see a need for that file to reside in the rsyslog repo.
>
> Regards,
>
>
>> On Oct 20, 2023, at 10:24, Rainer Gerhards via rsyslog <rsyslog@lists.adiscon.com> wrote:
>>
>> Hi all,
>>
>> the git repository contains rsyslog.service sample files. Actually,
>> these have not been updated for years and do no longer match distro
>> policies.
>>
>> Thankfully, Michael Biebl sent a PR to update the Debian parts. We had
>> a small discussion about the usefulness of these files at all. Michael
>> would be fine with removing them, and I think this is probably the
>> wisest thing to do. After all, these are not guinea rsyslog files.
>>
>> Instead, we can replace them with hints where to look inside the
>> distro repositories. But I would not tend to do big research to find
>> all of them.
>>
>> The PR is this one:
>>
>> https://github.com/rsyslog/rsyslog/pull/5252
>>
>> Question now: does anybody object to removing the rsyslog.service
>> files? If so, why is it important to keep them - and maybe how to
>> better maintain them.
>>
>> TIA,
>> Rainer
>> _______________________________________________
>> rsyslog mailing list
>> https://lists.adiscon.net/mailman/listinfo/rsyslog
>> http://www.rsyslog.com/professional-services/
>> What's up with rsyslog? Follow https://twitter.com/rgerhards
>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
>
> _______________________________________________
> rsyslog mailing list
> https://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
>
_______________________________________________
rsyslog mailing list
https://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.

Re: RFC: removing rsyslog.service samples from git [ In reply to ]

rsyslog at lists

Oct 22, 2023, 11:59 PM

Post #4 of 4 (146 views)

Permalink

Thanks for the comments. Done via

https://github.com/rsyslog/rsyslog/pull/5255

Rainer

El vie, 20 oct 2023 a las 18:33, David Lang via rsyslog
(<rsyslog@lists.adiscon.com>) escribió:
>
> Makes sense to me, they are far more dependent on the distro decisions than
> anything we provide.
>
> David Lang
>
> On Fri, 20 Oct 2023, John Chivian via rsyslog wrote:
>
> > Hi Rainer:
> >
> > Our source of truth for rsyslog.service has always been the copy packaged with the OS, and all modifications to it have come from vendor and systemd documentation. I do not personally see a need for that file to reside in the rsyslog repo.
> >
> > Regards,
> >
> >
> >> On Oct 20, 2023, at 10:24, Rainer Gerhards via rsyslog <rsyslog@lists.adiscon.com> wrote:
> >>
> >> Hi all,
> >>
> >> the git repository contains rsyslog.service sample files. Actually,
> >> these have not been updated for years and do no longer match distro
> >> policies.
> >>
> >> Thankfully, Michael Biebl sent a PR to update the Debian parts. We had
> >> a small discussion about the usefulness of these files at all. Michael
> >> would be fine with removing them, and I think this is probably the
> >> wisest thing to do. After all, these are not guinea rsyslog files.
> >>
> >> Instead, we can replace them with hints where to look inside the
> >> distro repositories. But I would not tend to do big research to find
> >> all of them.
> >>
> >> The PR is this one:
> >>
> >> https://github.com/rsyslog/rsyslog/pull/5252
> >>
> >> Question now: does anybody object to removing the rsyslog.service
> >> files? If so, why is it important to keep them - and maybe how to
> >> better maintain them.
> >>
> >> TIA,
> >> Rainer
> >> _______________________________________________
> >> rsyslog mailing list
> >> https://lists.adiscon.net/mailman/listinfo/rsyslog
> >> http://www.rsyslog.com/professional-services/
> >> What's up with rsyslog? Follow https://twitter.com/rgerhards
> >> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
> >
> > _______________________________________________
> > rsyslog mailing list
> > https://lists.adiscon.net/mailman/listinfo/rsyslog
> > http://www.rsyslog.com/professional-services/
> > What's up with rsyslog? Follow https://twitter.com/rgerhards
> > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
> >
> _______________________________________________
> rsyslog mailing list
> https://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
_______________________________________________
rsyslog mailing list
https://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.