Mailing List Archive

[Bug 404] ospf_write_frags() doesn't check return value of sendmsg()
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=404





------- Additional Comments From web@pilot.org.ua 2007-09-17 12:17 -------
Yes, a cornercase, but not a bug. Of course, it's more natural to start with the
default buffer size, so I will change that. But doing so will just hide the
original issue, but not fix it.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 404] ospf_write_frags() doesn't check return value of sendmsg() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=404





------- Additional Comments From web@pilot.org.ua 2007-09-17 12:49 -------
My best guess is that sendmsg() returns 0, when the message doesn't fit into
buffer (hence it's not fragmentable). This doesn't indicate an error, but should
be handled properly (attempt retried).

------- Additional Comments From paul@dishone.st 2007-09-20 12:16 -------
We likely shouldn't retry the send.

OSPF has higher-level mechanisms to cope with network problems (temporary
inability of an OS to send packets being such). Trying to provide reliability
/under/ those simply degrades their efficacy. ;)

It either gets sent (near) instantly, or we drop it, move on and let OSPF do its
thing.

At least, that should be the position we start from, and argue from there. ;)




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs