Mailing List Archive

[Bug 401] excessive logging by mes_lookup()
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401





------- Additional Comments From web@pilot.org.ua 2007-09-12 16:08 -------
Created an attachment (id=251)
--> (http://bugzilla.quagga.net/attachment.cgi?id=251&action=view)
proposed patch




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 401] excessive logging by mes_lookup() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401





------- Additional Comments From paul@dishone.st 2007-09-13 11:00 -------
I wouldn't object, I think Andrew objected even to the message being downgraded
to debug, but that was before considering prevalence of "sparse" code-spaces.

??




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 401] excessive logging by mes_lookup() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401


web@pilot.org.ua changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|paul@dishone.st |ajschorr@alumni.princeton.ed
| |u




------- Additional Comments From web@pilot.org.ua 2007-09-13 11:07 -------
Thanks. Andrew, what your objections are?



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 401] excessive logging by mes_lookup() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401





------- Additional Comments From ajschorr@alumni.princeton.edu 2007-09-13 13:25 -------
I have no objections to removing the debug message. Either it should
be an error, or there should be no message at all. Personally,
I would prefer that it be an error, but if people like the idea
of having arrays like capcode_str where the first few entries are
in the proper position, but the rest are not, then so be it.
Personally, I would prefer that the lookup function be used
in such cases, rather than mes_lookup. But in any case, the
debug message serves no purpose. Either it's an error, or it
isn't.

Regards,
Andy



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 401] excessive logging by mes_lookup() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401





------- Additional Comments From ajschorr@alumni.princeton.edu 2007-09-13 13:28 -------
So, just to be clear, the proper fix for the RTM_ADD error is to
replace all the instances of 'LOOKUP(rtm_type_str, rtm->rtm_type)'
with 'lookup(rtm_type_str, rtm->rtm_type)'. In my mind,
that's the proper fix for the problem.

Regards,
Andy



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs
[Bug 401] excessive logging by mes_lookup() [ In reply to ]
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug
report.

http://bugzilla.quagga.net/show_bug.cgi?id=401


web@pilot.org.ua changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #251 is|0 |1
obsolete| |






------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Quagga-bugs mailing list
Quagga-bugs@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-bugs