Mailing List Archive

gh-118039: Fix config.cache key on WASI (#118137)
https://github.com/python/cpython/commit/456c29cf85847c67dfc0fa36d6fe6168569b46fe
commit: 456c29cf85847c67dfc0fa36d6fe6168569b46fe
branch: main
author: Nice Zombies <nineteendo19d0@gmail.com>
committer: hugovk <1324225+hugovk@users.noreply.github.com>
date: 2024-04-23T10:46:28+03:00
summary:

gh-118039: Fix config.cache key on WASI (#118137)

files:
M .github/workflows/build.yml
M .github/workflows/reusable-wasi.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e1a2a62c60c6de..299c02e0944d42 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -137,6 +137,7 @@ jobs:
uses: actions/cache@v4
with:
path: config.cache
+ # Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python
key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-${{ needs.check_source.outputs.config_hash }}-${{ env.pythonLocation }}
- name: Install Dependencies
run: sudo ./.github/workflows/posix-deps-apt.sh
diff --git a/.github/workflows/reusable-wasi.yml b/.github/workflows/reusable-wasi.yml
index 60eef7bc478bbf..4a509a8acfee96 100644
--- a/.github/workflows/reusable-wasi.yml
+++ b/.github/workflows/reusable-wasi.yml
@@ -50,7 +50,8 @@ jobs:
uses: actions/cache@v4
with:
path: ${{ env.CROSS_BUILD_PYTHON }}/config.cache
- key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-${{ inputs.config_hash }}
+ # Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python
+ key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-${{ inputs.config_hash }}-${{ env.pythonLocation }}
- name: "Configure build Python"
run: python3 Tools/wasm/wasi.py configure-build-python -- --config-cache --with-pydebug
- name: "Make build Python"
@@ -59,7 +60,8 @@ jobs:
uses: actions/cache@v4
with:
path: ${{ env.CROSS_BUILD_WASI }}/config.cache
- key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-wasi-sdk-${{ env.WASI_SDK_VERSION }}-${{ inputs.config_hash }}
+ # Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python
+ key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-wasi-sdk-${{ env.WASI_SDK_VERSION }}-${{ inputs.config_hash }}-${{ env.pythonLocation }}
- name: "Configure host"
# `--with-pydebug` inferred from configure-build-python
run: python3 Tools/wasm/wasi.py configure-host -- --config-cache

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-leave@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: list-python-checkins@lists.gossamer-threads.com