Mailing List Archive

https://github.com/python/cpython/commit/fad48ea1816be3125ea51edcdfe2f999d6ade796
commit: fad48ea1816be3125ea51edcdfe2f999d6ade796
branch: 3.12
author: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
committer: encukou <encukou@gmail.com>
date: 2024-04-03T15:32:55+02:00
summary:

[3.12] gh-117166: Ignore empty and temporary dirs in `test_makefile` (GH-117190) (GH-117367)

gh-117166: Ignore empty and temporary dirs in `test_makefile` (GH-117190)
(cherry picked from commit d9cfe7e565a6e2dc15747a904736264e31a10be4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

files:
M Lib/test/test_tools/test_makefile.py

diff --git a/Lib/test/test_tools/test_makefile.py b/Lib/test/test_tools/test_makefile.py
index 7222a054dcd61c..17a1a6d0d38d7d 100644
--- a/Lib/test/test_tools/test_makefile.py
+++ b/Lib/test/test_tools/test_makefile.py
@@ -41,9 +41,17 @@ def test_makefile_test_folders(self):
self.assertIn(idle_test, test_dirs)

used = [idle_test]
- for dirpath, _, _ in os.walk(support.TEST_HOME_DIR):
+ for dirpath, dirs, files in os.walk(support.TEST_HOME_DIR):
dirname = os.path.basename(dirpath)
- if dirname == '__pycache__':
+ # Skip temporary dirs:
+ if dirname == '__pycache__' or dirname.startswith('.'):
+ dirs.clear() # do not process subfolders
+ continue
+ # Skip empty dirs:
+ if not dirs and not files:
+ continue
+ # Skip dirs with hidden-only files:
+ if files and all(filename.startswith('.') for filename in files):
continue

relpath = os.path.relpath(dirpath, support.STDLIB_DIR)

_______________________________________________
Python-checkins mailing list -- python-checkins@python.org
To unsubscribe send an email to python-checkins-leave@python.org
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: list-python-checkins@lists.gossamer-threads.com