Mailing List Archive

Roumen Petrov <bugtrack@roumenpetrov.info> added the comment:

I'm not sure that installation work if slash is removed and DESTDIR is
not specified. What about to replace "slash before $(DESTDIR)" with "/./" ?

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Jason Tishler <jason@tishler.net> added the comment:

Sorry for the delay, but I was on vacation and then recovering from
vacation...

You are correct that my initial patch does not handle the case when
DESTDIR is not specified. Your suggestion will work, but seems hacky.

What about adding the defaulting of DESTDIR to "/" to my initial
patch? This seems cleaner. See my second patch for the details.

If this approach is acceptable, then feel free to move the defaulting
of DESTDIR to a more appropriate place in Makefile.pre.in. I wasn't
sure where to put this change.

Added file: http://bugs.python.org/file12652/Makefile.pre.in.diff

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Roumen Petrov <bugtrack@roumenpetrov.info> added the comment:

Jason, did you test what is result is DESTDIR default to "/".

This variable(macro) is used with specific syntax by example (from
Makefile):
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$$b; \
where $$b is absolute path.

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Jason Tishler <jason@tishler.net> added the comment:

Obviously not... :,(

It seems like we might have to go with your "/./" workaround, but let
me see if I can come up with another approach.

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Changes by Roumen Petrov <bugtrack@roumenpetrov.info>:


Added file: http://bugs.python.org/file12725/py-issue-2233.patch

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Jason Tishler <jason@tishler.net> added the comment:

Your latest patch is on the right track, but see my latest one,
Makefile.pre.in.v2.diff, for an optimization. I tested make install
with and without DESTDIR defined on the command line and both cases
behaved as expected.

Added file: http://bugs.python.org/file12741/Makefile.pre.in.v2.diff

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Roumen Petrov <bugtrack@roumenpetrov.info> added the comment:

Hi Jason,
quick review without tests - I expect $${DESTDIR:-/} to work without :
in expression, i.e. just $${DESTDIR-/}.

The ":" in expression is not so portable (some shells fail on this).
Please see "Shell Substitutions" in autoconf manual.

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Jason Tishler <jason@tishler.net> added the comment:

I guess you mean the following:

${var:-value}
Old BSD shells, including the Ultrix sh, don't accept the colon for
any shell substitution, and complain and die.

If so, should we just go forward without the colon? The bash manpage
indicates the following:

In each of the cases below, ... bash tests for a parameter that is
unset or null; omitting the colon results in a test only for a
parameter that is unset.

So, if a user executes "make DESTDIR= install", then the build will
fail. Or, maybe we shouldn't worry about that corner case.

What do you think?

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Roumen Petrov <bugtrack@roumenpetrov.info> added the comment:

No response from py-dev list :( . May be solution has to work in all cases.

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue2233>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com