Mailing List Archive

STINNER Victor <vstinner@python.org> added the comment:


New changeset 63f102fe079ecb5cb7b921a1cf8bce4077a9d7e2 by Mohamed Koubaa in branch 'master':
bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (GH-21818)
https://github.com/python/cpython/commit/63f102fe079ecb5cb7b921a1cf8bce4077a9d7e2


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 1aaa21ff818b08af2a68862b552b7ba0857492eb by Mohamed Koubaa in branch 'master':
bpo-1635741 port zlib module to multi-phase init (GH-21995)
https://github.com/python/cpython/commit/1aaa21ff818b08af2a68862b552b7ba0857492eb


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 426f2b4f13f392875e7861dbd7f34735731eff17 by Mohamed Koubaa in branch 'master':
bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (GH-22050)
https://github.com/python/cpython/commit/426f2b4f13f392875e7861dbd7f34735731eff17


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 2aabc3200bf03d2ec1aa987e1e20db704948111e by Mohamed Koubaa in branch 'master':
bpo-1635741: Port _overlapped module to multi-phase init (GH-22051)
https://github.com/python/cpython/commit/2aabc3200bf03d2ec1aa987e1e20db704948111e


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21212
pull_request: https://github.com/python/cpython/pull/22131

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:

I closed the following issues as duplicates of this issue:

* bpo-15686: "PEP 3121, 384 Refactoring applied to md5 module"
* bpo-15733: "PEP 3121, 384 Refactoring applied to winapi module"
* bpo-15680: "PEP 3121 refactoring applied to audioop module"
* bpo-15706: "PEP 3121, 384 Refactoring applied to sha512 module"
* bpo-15704: "PEP 3121, 384 Refactoring applied to sha1 module"
* bpo-15681: "PEP 3121 refactoring applied to binascii module"
* bpo-15662: "PEP 3121 refactoring applied to locale module"

and also: bpo-31862: "Port the standard library to PEP 489 multiphase initialization" (binascii).

I also marked bpo-15682 "PEP 3121 refactoring applied to fpectl module" and bpo-15684 "PEP 3121 refactoring applied to fpetest module" as duplicates of bpo-29137: the fpectl module was removed in Python 3.7.

Note: _sha256 module is not ported yet (bpo-15705).

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21216
pull_request: https://github.com/python/cpython/pull/22134

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 1baf030a902392fe92d934ed0fb6a385cf7d8869 by Mohamed Koubaa in branch 'master':
bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (GH-21986)
https://github.com/python/cpython/commit/1baf030a902392fe92d934ed0fb6a385cf7d8869


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21223
pull_request: https://github.com/python/cpython/pull/22139

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21227
pull_request: https://github.com/python/cpython/pull/22145

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 15dcdb211366e0788e831fc2a1f785e6a5ca2749 by Mohamed Koubaa in branch 'master':
bpo-1635741: Port the termios to multi-phase init (PEP 489) (GH-22139)
https://github.com/python/cpython/commit/15dcdb211366e0788e831fc2a1f785e6a5ca2749


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:

I marked bpo-15709 "PEP 3121, 384 Refactoring applied to termios module" as a duplicate of this issue.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:

I rejected the PR 19122 which tries to port the _datetime module to the multi-phase initialization API (PEP 489). We need first to enhance the PyCapsule C API to pass the module instance to C functions, somehow.

Extension modules calling PyCapsule_New() in their init function:

* _curses
* _datetime
* _decimal
* _socket
* pyexpat
* unicodedata

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset 52a2df135c0470b1dbf889edc51b7c556ae4bc80 by Mohamed Koubaa in branch 'master':
bpo-1635741: Convert _sha256 types to heap types (GH-22134)
https://github.com/python/cpython/commit/52a2df135c0470b1dbf889edc51b7c556ae4bc80


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:

2020-06-22 16:58: "List of the 58 C extensions using the legacy API (...)"

UPDATE: 56% of Modules/*.c modules are converted (48 on 85).

Since June, 21 extension modules have been converted. There are now 37 remaining extensions which still use PyModule_Create():

$ grep -l '\<PyModule_Create\> *(' Modules/*.c|wc -l
37

Modules/*.c:

* 48 files use PyModuleDef_Init()
* 37 files use PyModule_Create()
* 9 files are not modules:

Modules/config.c
Modules/getaddrinfo.c
Modules/getbuildinfo.c
Modules/getnameinfo.c
Modules/getpath.c
Modules/main.c
Modules/_math.c
Modules/rotatingtree.c
Modules/tkappinit.c

--

Outside the Modules/ directory, there are 6 modules using PyModule_Create:

$ grep -l '\<PyModule_Create\> *(' */*.c|grep -v Modules

Objects/unicodeobject.c
PC/_msi.c
PC/msvcrtmodule.c
PC/winreg.c
PC/winsound.c
Python/import.c
Python/marshal.c
Python/_warnings.c

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by STINNER Victor <vstinner@python.org>:


----------
pull_requests: +21230
pull_request: https://github.com/python/cpython/pull/22148

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by STINNER Victor <vstinner@python.org>:


----------
pull_requests: +21231
pull_request: https://github.com/python/cpython/pull/22149

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:

> Python/_warnings.c

I'm not sure if it's a good idea to convert the _warnings module to multi-phase init, since it uses a state stored in the interpreter:

/* Given a module object, get its per-module state. */
static WarningsState *
warnings_get_state(void)
{
PyInterpreterState *interp = _PyInterpreterState_GET();
if (interp == NULL) {
PyErr_SetString(PyExc_RuntimeError,
"warnings_get_state: could not identify "
"current interpreter");
return NULL;
}
return &interp->warnings;
}

For example, two _warnings instance would share the _warnings.filters list. Maybe it's ok, I don't know.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset bb083d33f7ffe93cee9e1f63d1e526dc81a6e34f by Victor Stinner in branch 'master':
bpo-1635741: Port _string module to multi-phase init (GH-22148)
https://github.com/python/cpython/commit/bb083d33f7ffe93cee9e1f63d1e526dc81a6e34f


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset f315142ddc61e54a59028db562aec5f62db783e1 by Victor Stinner in branch 'master':
bpo-1635741: Port mashal module to multi-phase init (#22149)
https://github.com/python/cpython/commit/f315142ddc61e54a59028db562aec5f62db783e1


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21238
pull_request: https://github.com/python/cpython/pull/22164

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21239
pull_request: https://github.com/python/cpython/pull/22165

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Dong-hee Na <donghee.na92@gmail.com> added the comment:


New changeset 3ff6975e2c0af0399467f234b2e307cc76efcfa9 by Mohamed Koubaa in branch 'master':
bpo-1635741: port scproxy to multi-phase init (GH-22164)
https://github.com/python/cpython/commit/3ff6975e2c0af0399467f234b2e307cc76efcfa9


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

STINNER Victor <vstinner@python.org> added the comment:


New changeset f76d894dc5d5facce1a6c1b71637f6a2b3f9fd2b by Mohamed Koubaa in branch 'master':
bpo-1635741: Port cmath to multi-phase init (PEP 489) (GH-22165)
https://github.com/python/cpython/commit/f76d894dc5d5facce1a6c1b71637f6a2b3f9fd2b


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by mohamed koubaa <koubaa.m@gmail.com>:


----------
pull_requests: +21275
pull_request: https://github.com/python/cpython/pull/22220

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue1635741>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com