Mailing List Archive

TONYC Grant Report July 2023
[Hours] [Activity]
2023/07/03 Monday
0.92 #21181 fixes, testing, re-push and push to smoke-me
0.50 #21180 fixes, testing, push for re-CI
1.52 apply one of my PRs, look into unexpected mingw64 failure
on another PR
=====
2.94

2023/07/04 Tuesday
0.42 #21120 apply to blead, perldelta update, add to maint
votes
0.65 #21132, #21095 apply to blead, perldelta #21202 comment
0.08 #21118, #21060 apply to blead
0.28 #21031 apply to blead
0.85 #21041 testing, checks to see if regen changes meant this
needed updates, apply to blead
0.45 #21030 testing, apply to blead, perldelta
0.30 #21180 check CI results, apply to blead
1.37 #21202 look at mingw failure again, testing, comment
=====
4.40

2023/07/05 Wednesday
2.55 #21202 more testing, only happens when linking with -g,
doesn’t happen with gcc from WIP strawberry perl
3.03 #21202 work on trying to use mingw64 that’s meant to be
part of the runner
=====
5.58

2023/07/06 Thursday
1.65 #21202 mingw64 that’s part of the runner is old, install
using action, but it’s ucrt, see if we can detect that
0.98 #21202 work on ucrt support
=====
2.63

2023/07/10 Monday
0.68 #21212 research and comment
1.98 #21202 detect CRT type and pass it into the build, start
on adapting conditional compilation to match
1.22 #21202 more adaption, get it building, testing
=====
3.88

2023/07/11 Tuesday
1.60 #21202 clean up, work on adapting CI itself
3.20 #21202 testing, fix some issues, make PR #21234
=====
4.80

2023/07/12 Wednesday
0.38 #21202 change as suggested by xenu, push for CI
0.08 #21202 squash _UCRT re-work into original commit and re-
push
0.35 #21012 comment
0.13 review github notifications
1.08 #21176 fix issues, re-push
0.43 push revert for generate_uudmap change to CI
0.57 #21230 review, comment
0.20 #21227 review and approve
0.08 #21226 review and approve
0.15 #21225 review and approve
=====
3.45

2023/07/13 Thursday
1.50 #21012 follow-up, add a related fix, comment
0.10 generate_uudmap revert: make PR 21237
0.80 #21233 work on fix and testing, make into a branch on the
upstream and push for CI
0.13 #21233 clean up and make pr pjf/autodie#120
0.12 #21152 briefly comment
2.15 #21186 research, testing and comment
0.73 #21084 work on fixing format strings, side-tracked by
build issue, work it out, finish fix and update branch
=====
5.53

2023/07/17 Monday
0.13 #21240 comment
0.82 #21241 review and comments
2.40 #21186 have porting tests handle CRLF checkouts on Win32,
review some PRs while testing
=====
3.35

2023/07/18 Tuesday
0.35 #21230 comments
0.35 #21240 review updates and approve
0.17 #21252 research and comment
0.48 #21186 re-work, testing
0.32 #21186 recheck, push for CI
0.12 #21257 review and comment
0.73 #21256 review, some comments
=====
2.52

2023/07/19 Wednesday
0.08 #21257 comment about possible mis-close
0.18 #21241 follow-up
0.17 #21256 research
0.43 #21256 follow-up comment, separate comment on another
commit
0.23 #21266 review and approve
0.12 #21264 review and comment
=====
1.21

2023/07/20 Thursday
0.45 github notifications
0.92 #21265 review, research and approve
1.47 #20811 rebase, testing, re-check
0.13 #21152 apply to blead
0.43 #21233 make into a blead PR 21270
=====
3.40

2023/07/24 Monday
0.48 #21256 review new changes and approve
0.45 #21230 follow-up
0.38 PPC#36 review, re-check mailing list discussion
1.08 #21271 debug and work on a fix, testing, make PR 21284
1.17 try codeql on perl source, review results
=====
3.56

2023/07/25 Tuesday
0.65 #21271 apply to blead, add to votes files, perldelta
0.68 ppc#36 comment
0.05 #21287 review and approve
0.03 #21281 review and apply to blead
0.17 #21280 review, briefly research and comment
0.07 #21280 review changes, follow-up comment
1.75 #21286 review and approve
0.43 #21149 re-check and apply to blead
0.03 #21032 apply to blead
=====
3.86

2023/07/26 Wednesday
0.18 ppc#36 comment
0.80 #21290 research, comment
0.08 #21289 comment briefly
0.18 #21275 close
0.08 #21292 review and approve
0.05 #21285 review and approve
1.20 #21294 reviewing more locale changes
0.43 #21294 more reviewing more locale changes
0.10 #21211 review and approve
0.22 #21236 review and approve
0.18 #21012 rebase to get the mingw fix
0.18 #21187 work on a doc fix
1.40 try -Wshadow, work on -Wconversion fixes (since it detects
some known issues)
=====
5.08

2023/07/27 Thursday
0.60 #21294 research, follow-up
0.77 more -Wconversion
0.50 #21187 make the doc update more complete, make PR 21298
0.95 #21297 testing, comment
0.70 #21012 apply to blead and perldelta
0.65 #20990 rebase and testing
0.62 more -Wconversion
=====
4.79

2023/07/31 Monday
0.40 #21297 review new patch and approve
0.33 #21294 review changes and approve
0.20 #21298 minor update
0.60 #21310 review, testing (and find -Dusequadmath -Dclang
doesn’t work with or without this change), approve
0.07 #21302 review and approve
0.15 #21304 research
0.37 #20811 rebase and apply to blead
0.48 look at some win32/gnumakefile optimization fixes
0.32 #21312 review and approve
1.07 more win32/gnumakefile, testing
0.07 #21298 apply to blead
0.12 #21313 research
=====
4.18

Which I calculate is 65.16 hours.

Approximately 54 tickets were reviewed or worked on, and 15 patches
were applied.
Re: TONYC Grant Report July 2023 [ In reply to ]
On Mon, Aug 21, 2023 at 8:30?PM Tony Cook <tony@develop-help.com> wrote:

> 1.17 try codeql on perl source, review results
>

Oh interesting. Is there any more info you have on this? (How you run it on
perl, etc..., results...?)


> Which I calculate is 65.16 hours.
>

Thanks Tony, +1 from me.

-- Matthew Horsfall (alh)
Re: TONYC Grant Report July 2023 [ In reply to ]
On Tue, Aug 22, 2023 at 08:06:31AM -0400, Matthew Horsfall (alh) wrote:
> On Mon, Aug 21, 2023 at 8:30?PM Tony Cook <tony@develop-help.com> wrote:
>
> > 1.17 try codeql on perl source, review results
> >
>
> Oh interesting. Is there any more info you have on this? (How you run it on
> perl, etc..., results...?)

The github tool does a decent job in setting this up, though you do
need to tell the workflow about the build process, see:

https://github.com/tonycoz/perl5/commits/codeql

I don't know if this is visible to anyone but me:

https://github.com/tonycoz/perl5/security/code-scanning?query=is%3Aopen+branch%3Acodeql

If it isn't I don't see a way to make it visible to anyone else, I
suspect I'd need an organization for that to work.

I've rebased it and pushed to the tonyc/codeql branch on
Perl/perl5.git, so hopefully the results will be visible to members
there once the workflow finishes, presumably under:

https://github.com/Perl/perl5/security/code-scanning?query=is%3Aopen+branch%3Atonyc/codeql

(right now it just offers to configure code scanning.)

Some of the results it returns (like cpp/pointer-overflow-check) seem
like nonsense, not matching the described problem.

Some seem reasonable, like loop variables being smaller types then
their limits.

(trimmed CC)

Tony
Re: TONYC Grant Report July 2023 [ In reply to ]
On Tue, Aug 22, 2023 at 9:03?AM Tony Cook <tony@develop-help.com> wrote:

> On Tue, Aug 22, 2023 at 08:06:31AM -0400, Matthew Horsfall (alh) wrote:
> > On Mon, Aug 21, 2023 at 8:30?PM Tony Cook <tony@develop-help.com> wrote:
> >
> > > 1.17 try codeql on perl source, review results
> > >
> >
> > Oh interesting. Is there any more info you have on this? (How you run it
> on
> > perl, etc..., results...?)
>
> The github tool does a decent job in setting this up, though you do
> need to tell the workflow about the build process, see [...]
>

Fantastic, thanks. The links work for me when logged in to Github, at least.

-- Matthew Horsfall (alh)