Mailing List Archive

For SunOS 4.x atexit() needs to be #defined to on_exit() somewhere.
Other than that, it seems to work fine on SunOS 4.1.3.

- todd

On Sat, May 20, 2000 at 07:13:06PM +1000, Damien Miller wrote:

[...]

> >From now on all portable releases will have a 'p' suffix to
> distinguish them from the official OpenBSD source.

This tends to be a tad confusing. I though that the 'p' suffix
meant "patch level". I would be a little concerned that someone who
doesn't already no that will also jump to that conclusion.

Just an observation. I don't have any better alternatives or
suggestions...

> Thanks to all those who submitted bug reports and patches.

> Regards,
> Damien Miller

Thanks for all the work. (I've got OpenSSH 2.1.0p2 running on
about a dozen systems right now - Good job!)

Mike
--
Michael H. Warfield | (770) 985-6132 | mhw@WittsEnd.com
(The Mad Wizard) | (770) 331-2437 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0xDF1DD471 | possible worlds. A pessimist is sure of it!

On Sat, 20 May 2000, Todd C. Miller wrote:

> For SunOS 4.x atexit() needs to be #defined to on_exit() somewhere.
> Other than that, it seems to work fine on SunOS 4.1.3.

This OK?

Index: configure.in
===================================================================
RCS file: /var/cvs/openssh/configure.in,v
retrieving revision 1.126
diff -u -r1.126 configure.in
--- configure.in 2000/05/20 05:33:45 1.126
+++ configure.in 2000/05/21 01:51:55
@@ -135,7 +135,7 @@
AC_CHECK_HEADERS(bstring.h endian.h lastlog.h login.h maillock.h netdb.h netgroup.h netinet/in_systm.h paths.h poll.h pty.h shadow.h security/pam_appl.h sys/bitypes.h sys/bsdtty.h sys/cdefs.h sys/poll.h sys/select.h sys/stropts.h sys/sysmacros.h sys/time.h sys/ttcompat.h stddef.h util.h utmp.h utmpx.h)

# Checks for library functions.
-AC_CHECK_FUNCS(arc4random b64_ntop bcopy bindresvport_af clock freeaddrinfo gai_strerror getaddrinfo getnameinfo getrusage innetgr md5_crypt memmove mkdtemp openpty rresvport_af setenv seteuid setlogin setproctitle setreuid snprintf strlcat strlcpy updwtmpx vsnprintf vhangup _getpty __b64_ntop)
+AC_CHECK_FUNCS(arc4random atexit b64_ntop bcopy bindresvport_af clock freeaddrinfo gai_strerror getaddrinfo getnameinfo getrusage innetgr md5_crypt memmove mkdtemp on_exit openpty rresvport_af setenv seteuid setlogin setproctitle setreuid snprintf strlcat strlcpy updwtmpx vsnprintf vhangup _getpty __b64_ntop)

AC_CHECK_FUNC(login,
[AC_DEFINE(HAVE_LOGIN)],
Index: defines.h
===================================================================
RCS file: /var/cvs/openssh/defines.h,v
retrieving revision 1.21
diff -u -r1.21 defines.h
--- defines.h 2000/05/17 12:53:35 1.21
+++ defines.h 2000/05/21 01:51:55
@@ -293,4 +293,8 @@
# define memmove(s1, s2, n) bcopy((s2), (s1), (n))
#endif /* !defined(HAVE_MEMMOVE) && defined(HAVE_BCOPY) */

+#if !defined(HAVE_ATEXIT) && defined(HAVE_ON_EXIT)
+# define atexit(a) on_exit(a)
+#endif /* !defined(HAVE_ATEXIT) && defined(HAVE_ON_EXIT) */
+
#endif /* _DEFINES_H */


Thanks,
Damien Miller

--
| "Bombay is 250ms from New York in the new world order" - Alan Cox
| Damien Miller - http://www.mindrot.org/
| Email: djm@mindrot.org (home) -or- djm@ibs.com.au (work)

Looks fine, although you might want to move the check into the
*-*-sunos4* portion since there's really no need for it on other
OSes.

- todd

In message <Pine.LNX.4.21.0005211152060.5199-100000@mothra.mindrot.org>
so spake Damien Miller (djm):

> On Sat, 20 May 2000, Todd C. Miller wrote:
>
> > For SunOS 4.x atexit() needs to be #defined to on_exit() somewhere.
> > Other than that, it seems to work fine on SunOS 4.1.3.
>
> This OK?
>
> Index: configure.in
> ===================================================================
> RCS file: /var/cvs/openssh/configure.in,v
> retrieving revision 1.126
> diff -u -r1.126 configure.in
> --- configure.in 2000/05/20 05:33:45 1.126
> +++ configure.in 2000/05/21 01:51:55
> @@ -135,7 +135,7 @@
> AC_CHECK_HEADERS(bstring.h endian.h lastlog.h login.h maillock.h netdb.h net
> group.h netinet/in_systm.h paths.h poll.h pty.h shadow.h security/pam_appl.h
> sys/bitypes.h sys/bsdtty.h sys/cdefs.h sys/poll.h sys/select.h sys/stropts.h
> sys/sysmacros.h sys/time.h sys/ttcompat.h stddef.h util.h utmp.h utmpx.h)
>
> # Checks for library functions.
> -AC_CHECK_FUNCS(arc4random b64_ntop bcopy bindresvport_af clock freeaddrinfo
> gai_strerror getaddrinfo getnameinfo getrusage innetgr md5_crypt memmove mkdt
> emp openpty rresvport_af setenv seteuid setlogin setproctitle setreuid snprin
> tf strlcat strlcpy updwtmpx vsnprintf vhangup _getpty __b64_ntop)
> +AC_CHECK_FUNCS(arc4random atexit b64_ntop bcopy bindresvport_af clock freead
> drinfo gai_strerror getaddrinfo getnameinfo getrusage innetgr md5_crypt memmo
> ve mkdtemp on_exit openpty rresvport_af setenv seteuid setlogin setproctitle
> setreuid snprintf strlcat strlcpy updwtmpx vsnprintf vhangup _getpty __b64_nt
> op)
>
> AC_CHECK_FUNC(login,
> [AC_DEFINE(HAVE_LOGIN)],
> Index: defines.h
> ===================================================================
> RCS file: /var/cvs/openssh/defines.h,v
> retrieving revision 1.21
> diff -u -r1.21 defines.h
> --- defines.h 2000/05/17 12:53:35 1.21
> +++ defines.h 2000/05/21 01:51:55
> @@ -293,4 +293,8 @@
> # define memmove(s1, s2, n) bcopy((s2), (s1), (n))
> #endif /* !defined(HAVE_MEMMOVE) && defined(HAVE_BCOPY) */
>
> +#if !defined(HAVE_ATEXIT) && defined(HAVE_ON_EXIT)
> +# define atexit(a) on_exit(a)
> +#endif /* !defined(HAVE_ATEXIT) && defined(HAVE_ON_EXIT) */
> +
> #endif /* _DEFINES_H */
>
>
> Thanks,
> Damien Miller
>
> --
> | "Bombay is 250ms from New York in the new world order" - Alan Cox
> | Damien Miller - http://www.mindrot.org/
> | Email: djm@mindrot.org (home) -or- djm@ibs.com.au (work)

On Sat, 20 May 2000, Todd C. Miller wrote:

> Looks fine, although you might want to move the check into the
> *-*-sunos4* portion since there's really no need for it on other
> OSes.

Well, it will only be acitvated if the other OS lacks atexit(), but
has on_exit(). Do you know of any?

-d

--
| "Bombay is 250ms from New York in the new world order" - Alan Cox
| Damien Miller - http://www.mindrot.org/
| Email: djm@mindrot.org (home) -or- djm@ibs.com.au (work)

In message <Pine.LNX.4.21.0005211200190.5199-100000@mothra.mindrot.org>
so spake Damien Miller (djm):

> Well, it will only be acitvated if the other OS lacks atexit(), but
> has on_exit(). Do you know of any?

No, I don't. It's just that configure scripts with lots of tests
can take a long time to run so I didn't see the point in the non-sunos
case.

- todd