Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|WONTFIX |---
CC| |dtucker@dtucker.net

--- Comment #2 from Darren Tucker <dtucker@dtucker.net> ---
This is about the output of "sshd -V" not the version in the protocol
output:

There's two version identifiers in version.h, the base OpenSSH version
and the -portable version:

#define SSH_VERSION "OpenSSH_9.4"
#define SSH_PORTABLE "p1"
#define SSH_RELEASE SSH_VERSION SSH_PORTABLE

Upstream (OpenBSD) only uses SSH_VERSION.

ssh.c uses SSH_RELEASE (the full version) and has for a long, long time
(https://github.com/openssh/openssh-portable/commit/2aa6d3cfce738f57c31ae676e11399382bd5660e):

case 'V':
fprintf(stderr, "%s, %s\n",
SSH_RELEASE, SSH_OPENSSL_VERSION);

When sshd -V was added in OpenBSD it used SSH_VERSION (the base
version), and when it was synced into -portable this was brought over
without change
((https://github.com/openssh/openssh-portable/commit/7d17ea151c0b2519f023bd9cc7f141128833ac47):

case 'V':
fprintf(stderr, "%s, %s\n",
SSH_VERSION, SSH_OPENSSL_VERSION);

I contend sshd -V should match ssh -V behaviour.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3723| |ok?(djm@mindrot.org)
Flags| |

--- Comment #3 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3723
--> https://bugzilla.mindrot.org/attachment.cgi?id=3723&action=edit
include portable version in sshd -V output

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

--- Comment #4 from yataosu@gmail.com <yataosu@gmail.com> ---
(In reply to Damien Miller from comment #1)
> sshd doesn't print the portable patch version in its output because
> it is irrelevant - portable patch releases don't change the protocol.

Is this means when openssh has a major release, like 9.2 -> 9.3, the
protocol has changed, so sshd version changed too?

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

--- Comment #5 from yataosu@gmail.com <yataosu@gmail.com> ---
(In reply to Darren Tucker from comment #2)
> This is about the output of "sshd -V" not the version in the
> protocol output:
>
> There's two version identifiers in version.h, the base OpenSSH
> version and the -portable version:
>
> #define SSH_VERSION "OpenSSH_9.4"
> #define SSH_PORTABLE "p1"
> #define SSH_RELEASE SSH_VERSION SSH_PORTABLE
>
> Upstream (OpenBSD) only uses SSH_VERSION.
>
> ssh.c uses SSH_RELEASE (the full version) and has for a long, long
> time
> (https://github.com/openssh/openssh-portable/commit/
> 2aa6d3cfce738f57c31ae676e11399382bd5660e):
>
> case 'V':
> fprintf(stderr, "%s, %s\n",
> SSH_RELEASE, SSH_OPENSSL_VERSION);
>
> When sshd -V was added in OpenBSD it used SSH_VERSION (the base
> version), and when it was synced into -portable this was brought
> over without change
> ((https://github.com/openssh/openssh-portable/commit/
> 7d17ea151c0b2519f023bd9cc7f141128833ac47):
>
> case 'V':
> fprintf(stderr, "%s, %s\n",
> SSH_VERSION, SSH_OPENSSL_VERSION);
>
> I contend sshd -V should match ssh -V behaviour.

Yeah, I saw this version logic in ssh.c sshd.c, and I very agreed with
you, this two version should matched.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3723| |ok+
Flags| |

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
Blocks| |3605

--- Comment #6 from Darren Tucker <dtucker@dtucker.net> ---
Patch applied and will be in the next release. Thanks.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3605
[Bug 3605] Tracking bug for OpenSSH 9.5
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3608

--- Comment #7 from yataosu@gmail.com <yataosu@gmail.com> ---
(In reply to Darren Tucker from comment #6)
> Patch applied and will be in the next release. Thanks.

Nice. Thank you!

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs