Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=1412





--- Comment #8 from Disco Vince Giffin <vgiffin@apple.com> 2009-01-14 09:05:23 ---
(In reply to comment #7)
> Won't a similar call to initgroups() need to be in
> permanently_drop_suid() and restore_uid() too?

No, because setgid() isn't called from permanently_drop_suid() and
restore_uid() is restoring the original (privileged) uid.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412





--- Comment #9 from Damien Miller <djm@mindrot.org> 2009-01-14 13:31:30 ---
Sorry, I meant temporarily_use_uid(), not permanently_drop_suid()

temporarily_use_uid() calls setgroups(), does that opt out of memberd?

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412





--- Comment #10 from Disco Vince Giffin <vgiffin@apple.com> 2009-01-15 08:09:08 ---
(In reply to comment #9)
> Sorry, I meant temporarily_use_uid(), not permanently_drop_suid()
>
> temporarily_use_uid() calls setgroups(), does that opt out of memberd?

No. The call to setgroups() in temporarily_use_uid() should be fine.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412


Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1407|0 |1
is obsolete| |
Attachment #1407|ok?(dtucker@zip.com.au) |
Flag| |
Attachment #1592| |ok?(dtucker@zip.com.au)
Flag| |




--- Comment #11 from Damien Miller <djm@mindrot.org> 2009-01-15 11:12:26 ---
Created an attachment (id=1592)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1592)
wrap in __APPLE__ and comment

This is the diff I'd like to commit then.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412


Darren Tucker <dtucker@zip.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1592| |ok+
Flag| |




--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412


Darren Tucker <dtucker@zip.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1592|ok?(dtucker@zip.com.au) |ok+
Flag| |




--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412


Darren Tucker <dtucker@zip.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|scp |sshd




--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=1412


Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED




--- Comment #12 from Damien Miller <djm@mindrot.org> 2009-01-21 16:08:21 ---
fix applied - will be in openssh-5.2. Thanks!

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs