Mailing List Archive: [Bug 1538] improve SSP detection

[Bug 1538] improve SSP detection

Nov 18, 2008, 8:29 PM

Post #1 of 5 (1007 views)

https://bugzilla.mindrot.org/show_bug.cgi?id=1538

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned-bugs@mindrot.org |djm@mindrot.org
Attachment #1579| |ok?
Flag| |

--- Comment #1 from Damien Miller <djm@mindrot.org> 2008-11-19 15:29:50 ---
Created an attachment (id=1579)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1579)
Fixed patch

I think the referenced patch is incorrect: square brackets need
escaping in autoconf, so the test program would always fail with a
compile error. This patch uses autoconf "quadrigraph" escaping (don't
ask) to avoid this.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1538] improve SSP detection [ In reply to ]

bugzilla-daemon at bugzilla

Nov 18, 2008, 8:30 PM

Post #2 of 5 (938 views)

Permalink

https://bugzilla.mindrot.org/show_bug.cgi?id=1538

--- Comment #2 from Damien Miller <djm@mindrot.org> 2008-11-19 15:30:53 ---
oops, ignore the changes to Makefile.in in that diff - they aren't
supposed to be there.

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1538] improve SSP detection [ In reply to ]

bugzilla-daemon at bugzilla

Nov 18, 2008, 9:57 PM

Post #3 of 5 (931 views)

Permalink

https://bugzilla.mindrot.org/show_bug.cgi?id=1538

Tim Rice <tim@multitalents.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tim@multitalents.net

--- Comment #3 from Tim Rice <tim@multitalents.net> 2008-11-19 16:57:35 ---
(In reply to comment #1)
> I think the referenced patch is incorrect: square brackets need
> escaping in autoconf, so the test program would always fail with a
> compile error. This patch uses autoconf "quadrigraph" escaping (don't
> ask) to avoid this.

Or you can just double up on the square brackets. More readable?
+int main(void){char x[[256]]; snprintf(x, sizeof(x), "XXX"); return
0;}

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1538] improve SSP detection [ In reply to ]

bugzilla-daemon at bugzilla

Nov 18, 2008, 10:11 PM

Post #4 of 5 (943 views)

Permalink

https://bugzilla.mindrot.org/show_bug.cgi?id=1538

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1579|0 |1
is obsolete| |
Attachment #1579|ok? |
Flag| |
Attachment #1580| |ok?
Flag| |

--- Comment #4 from Damien Miller <djm@mindrot.org> 2008-11-19 17:11:39 ---
Created an attachment (id=1580)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=1580)
simplified diff

diff with Tim's suggestion and no extraneous crap

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1538] improve SSP detection [ In reply to ]

bugzilla-daemon at bugzilla

Nov 19, 2008, 4:17 PM

Post #5 of 5 (926 views)

Permalink

https://bugzilla.mindrot.org/show_bug.cgi?id=1538

--- Comment #5 from Mike Frysinger <vapier@gentoo.org> 2008-11-20 11:17:30 ---
indeed ... i should have checked the config.log rather than just
verifying that SSP was detected as not supported

--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs