Mailing List Archive: [Bug 1243] Multiple including of paths.h on AIX 5.1 systems.

http://bugzilla.mindrot.org/show_bug.cgi?id=1243

Summary: Multiple including of paths.h on AIX 5.1 systems.
Product: Portable OpenSSH
Version: 4.4p1
Platform: All
OS/Version: AIX
Status: NEW
Severity: normal
Priority: P2
Component: Build system
AssignedTo: bitbucket@mindrot.org
ReportedBy: pirzyk@uiuc.edu

This is due to including paths.h from multiple locations. It is
included via includes.h as well as directly in the following c files:

./auth.c
./clientloop.c
./loginrec.c
./misc.c
./monitor.c
./readpass.c
./session.c
./sftp.c
./ssh-agent.c
./ssh-keygen.c
./ssh-keysign.c
./ssh.c
./sshconnect.c
./sshd.c
./sshpty.c

Removing the following code fragment from the c files allows OpenSSH to
compile on AIX:

#ifdef HAVE_PATHS_H
# include <paths.h>
#endif

For reference, here is a compile time error message:

xlc -O2 -I. -I. -I/usr/local/encap/zlib-1.1.4/include
-I/usr/local/encap/openssl-0.9.7l/include
-I/usr/local/encap/tcp_wrappers-7.6+6/include -DSSHDIR=\"/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/encap/openssh-4.4p1/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/encap/openssh-4.4p1/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/encap/openssh-4.4p1/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/encap/openssh-4.4p1/libexec/ssh-keysign\"
-D_PATH_SSH_PIDDIR=\"/etc\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DSSH_RAND_HELPER=\"/usr/local/encap/openssh-4.4p1/libexec/ssh-rand-helper\"
-DHAVE_CONFIG_H -c readpass.c
"/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL
cannot be redefined.
"/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is
defined on line 322 of defines.h.
"/usr/include/paths.h", line 52.9: 1506-213 (S) Macro name _PATH_CSHELL
cannot be redefined.
"/usr/include/paths.h", line 52.9: 1506-358 (I) "_PATH_CSHELL" is
defined on line 325 of defines.h.
"/usr/include/paths.h", line 57.9: 1506-213 (S) Macro name
_PATH_MAILDIR cannot be redefined.
"/usr/include/paths.h", line 57.9: 1506-358 (I) "_PATH_MAILDIR" is
defined on line 359 of defines.h.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs

http://bugzilla.mindrot.org/show_bug.cgi?id=1243

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
OtherBugsDependingO| |1222
nThis| |

------- Comment #1 from dtucker@zip.com.au 2006-10-03 19:49 -------
(In reply to comment #0)
> This is due to including paths.h from multiple locations. It is
> included via includes.h as well as directly in the following c files:

Actually it's not a multiple include, but defines.h redefines the
things that paths.h sets. Removing paths.h isn't really the right way
to fix it (we should use the ones provided by the system where
possible) but it should indeed be fixed.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs