Mailing List Archive

[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO)
http://bugzilla.mindrot.org/show_bug.cgi?id=1221

Summary: Banner only suppressed at log level = QUIET (used to be
at log level < INFO)
Product: Portable OpenSSH
Version: 4.3p2
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: ssh
AssignedTo: bitbucket@mindrot.org
ReportedBy: Dean.Kopesky@reuters.com


I don't know whether this counts as a "bug" or a "feature", but I
figured I'd report it....

Prior to version 3.8, the pre-authentication banner (e.g., /etc/issue)
was suppressed at LogLevel=ERROR|FATAL|QUIET. Since 3.8, it has only
been suppressed at LogLevel=QUIET. This change was a side-effect of
the following mod:

- dtucker@cvs.openbsd.org 2003/10/07 01:47:27
[sshconnect2.c]
Don't use logit for banner, since it truncates to MSGBUFSIZ;
bz #668 & #707. ok markus@

The relevant code is in sshconnect2.c:

input_userauth_banner(int type, u_int32_t seq, void *ctxt)
{
char *msg, *lang;

debug3("input_userauth_banner");
msg = packet_get_string(NULL);
lang = packet_get_string(NULL);
if (options.log_level > SYSLOG_LEVEL_QUIET)
fprintf(stderr, "%s", msg);
xfree(msg);
xfree(lang);
}

Was this change in the log level at which the banner prints
intentional?

When ssh is used inside scripts, or forked inside programs, it is (or
rather, was) very nice to be able to suppress the banner, but still get
error messages. However, we must now choose both or neither.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221





------- Comment #1 from dtucker@zip.com.au 2006-08-29 00:02 -------
There was no deliberate change in behaviour so if there is one it was
unintentional.

That said, I can't see a difference here: "ssh -q" and "ssh -o
loglevel=quiet" both behave the same now and with the diff reverted.
Could you please give an example? (also what platform are you running
on, in case it matters?)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221





------- Comment #2 from Dean.Kopesky@reuters.com 2006-08-29 23:58 -------
-o LogLevel=QUIET works the same before and after the diff, yes.

The problem is that -o LogLevel=ERROR and -o LogLevel=FATAL suppressed
the banner before the diff, but don't suppress the banner after.

This is because, before the diff, input_userauth_banner() printed the
banner with logit(), which uses a log level of INFO internally; whereas
after the diff, input_userauth_banner() hardcodes a check for
LOG_LEVEL_QUIET.

We are running on various Sun Sparc machines, with Solaris 5.6, 5.8,
and 5.10. I can see the cause of the behavior in the source code,
though, so I doubt the behavior is platform-specific.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221


dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED




------- Comment #3 from dtucker@zip.com.au 2006-08-30 00:23 -------
Ah, I see. So if the test was "if (options.log_level >=
LOG_LEVEL_INFO)" then it would have the previous behaviour?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221





------- Comment #4 from Dean.Kopesky@reuters.com 2006-08-30 00:40 -------
I believe that is correct, yes.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221


djm@mindrot.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
BugsThisDependsOn| |1155




------- Comment #5 from djm@mindrot.org 2006-08-30 11:11 -------
Darren applied his patch, so it will be in the 4.4p1 release - thanks




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1221] Banner only suppressed at log level = QUIET (used to be at log level < INFO) [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=1221


dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn|1155 |
OtherBugsDependingO| |1155
nThis| |




------- Comment #6 from dtucker@zip.com.au 2006-08-30 19:51 -------
Oops, that should have been "blocks bug #1155" not "depends on bug
#1155".




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
http://lists.mindrot.org/mailman/listinfo/openssh-bugs